Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add InstanceOptions with LocalDiskStrategy #1688

Merged
merged 10 commits into from
Feb 27, 2024
Merged

Conversation

cartermckinnon
Copy link
Member

@cartermckinnon cartermckinnon commented Feb 23, 2024

Description of changes:

We've removed the default raid0 setup in #1686, so this adds the ability to setup local disks in NodeConfig.

Example:

---
apiVersion: node.eks.aws/v1alpha1
kind: NodeConfig
spec:
  instance:
    localStorage:
      strategy: RAID0

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@cartermckinnon
Copy link
Member Author

Some kind of issue going on with the conversion-gen check, when I run locally the file has an empty diff 🤔

@cartermckinnon
Copy link
Member Author

cartermckinnon commented Feb 23, 2024

Fixed it by adding --output-base to the conversion-gen command. This will default to $GOPATH/src when GOPATH is defined -- it's usually defined on a dev's laptop, but isn't in the GitHub Actions runner.

nodeadm/internal/system/local_disk.go Outdated Show resolved Hide resolved
nodeadm/internal/system/local_disk.go Outdated Show resolved Hide resolved
nodeadm/api/v1alpha1/nodeconfig_types.go Show resolved Hide resolved
@cartermckinnon cartermckinnon merged commit bf4c549 into main Feb 27, 2024
10 checks passed
@cartermckinnon cartermckinnon deleted the local-disk-strategy branch February 27, 2024 05:37
atmosx pushed a commit to gathertown/amazon-eks-ami that referenced this pull request Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants