Fix calls to management canister #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue in the RequestID computation where an empty slice canister ID would be considered as "canister_id not set". This was not quite correct, because the management canister ID is the empty slice (encoded as "aaaaa-aa"). This changes the empty check for a `nil` check instead. Usages of the effective canister ID vs. canister ID are also clarified.
nmattia
commented
Mar 26, 2024
|
Thanks for helping with this @peterpeterparker and @frederikrothenberger! |
|
@q-uint thanks for the feedback! I'll implement everything tomorrow. Apologies for the Go noob mistakes :) |
q-uint
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue in the RequestID computation where an empty slice canister ID would be considered as "canister_id not set". This was not quite correct, because the management canister ID is the empty slice (encoded as "aaaaa-aa").
This changes the empty check for a
nilcheck instead. Usages of the effective canister ID vs. canister ID are also clarified.This also changes the way the logger prints the request ID to use a hex representation, which is easier to read & convert than the byte characters.