Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_localization_component_launch): change the default input pointcloud of localization into the concatenated pointcloud #899

Conversation

TaikiYamada4
Copy link
Contributor

@TaikiYamada4 TaikiYamada4 commented Mar 1, 2024

Description

Autoware should cover the use cases where the concatenated pointcloud will be applied as an input to the localization, and we expect that the number of vehicles that use multiple LiDARs will increase..

Therefore, this PR will change the default input_pointcloud to /sensing/lidar/concatenated/pointcloud instead of /sensing/lidar/top/pointcloud, and change the pointcloud container to /pointcloud_container due to this change.

Plus, I also refactored the name of the argument lidar_container_name to localization_pointcloud_container_name since the candidate pointcloud container may not be specific to such LiDAR (just like this case), and it makes the argument more clear that it is for the localization component.

Of course, this is just a modification of the default input_pointcloud, so one can choose to use a single LiDAR by changing the input_pointcloud to /sensing/lidar/***/pointcloud.

Related links

This PR must be merged with autowarefoundation/autoware.universe#6528!!

Tests performed

Confirmed that the localization worked with the concatenated pointcloud in the logging_simulator tutorial.
Also tested with internal driving data, and evaluated through CARET that it hardly affected the system latency. [TIER IV INTERNAL LINK]

Notes for reviewers

This PR must be merged with autowarefoundation/autoware.universe#6528!!

Interface changes

The localization component will use /sensing/lidar/concatenated/pointcloud by default.
The pointcloud preprocessing nodes in the localization component will join the pointcloud_container by default.

Effects on system behavior

The localization component will use /sensing/lidar/concatenated/pointcloud by default.
The pointcloud preprocessing nodes in the localization component will join the pointcloud_container by default.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
@TaikiYamada4 TaikiYamada4 changed the title feat(tier4_localization_component_launch): Change the default input pointcloud of localization into the concatenated pointcloud feat(tier4_localization_component_launch): change the default input pointcloud of localization into the concatenated pointcloud Mar 1, 2024
@TaikiYamada4 TaikiYamada4 marked this pull request as ready for review March 1, 2024 08:11
Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have confirmed that the logging_simulator runs with the same accuracy as before on AWSIM data with GT.
Looks Good To Me

@TaikiYamada4 TaikiYamada4 merged commit c03bd4b into autowarefoundation:main Mar 4, 2024
9 of 10 checks passed
go-sakayori added a commit to tier4/autoware_launch that referenced this pull request Aug 7, 2024
…n#899)

* add parameter for force slow driving

Signed-off-by: Go Sakayori <gsakayori@gmail.com>

* fix

Signed-off-by: Go Sakayori <gsakayori@gmail.com>

* modify comment

Signed-off-by: Go Sakayori <gsakayori@gmail.com>

---------

Signed-off-by: Go Sakayori <gsakayori@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants