Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(occupancy_grid_map): add occupancy_grid_map method/param var to launcher #294

Merged

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Apr 13, 2023

add occupancy_grid_map method/param var to launcher and use those ones in autoware_launch by default

Description

Just like other packages I changed the auoware_launch to refer to launcher param file.

Related links

universe PR: autowarefoundation/autoware.universe#3393

Tests performed

Psim works as before.

Interface changes

None

Effects on system behavior

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

…es in autoware_launch by default

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@soblin soblin force-pushed the feat/add-config-for-occupancy-grid-map branch from de1922a to 5e4e448 Compare April 13, 2023 11:58
@soblin soblin marked this pull request as ready for review April 13, 2023 12:09
@soblin soblin requested a review from YoshiRi April 13, 2023 12:26
Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and psim worked.

image

@YoshiRi
Copy link
Contributor

YoshiRi commented Apr 14, 2023

Lsim also worked 👍
image width=500

tkimura4 referenced this pull request in tier4/autoware_launch Apr 18, 2023
* feat(planning_error_monitor): read params from yaml

* fix(planning_error_monitor): fix the parameter to paramter in universe.

* fix: add units of some parameters in yaml
@soblin soblin merged commit fa42762 into autowarefoundation:main Apr 19, 2023
@soblin soblin deleted the feat/add-config-for-occupancy-grid-map branch April 19, 2023 03:59
soblin pushed a commit to soblin/autoware_launch that referenced this pull request May 7, 2023
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
badai-nguyen pushed a commit to badai-nguyen/autoware_launch that referenced this pull request Apr 16, 2024
…in-sync

chore: sync beta branch beta/v0.21.0 with tier4/main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants