Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(obstacle_cruise_planner): clean up a part of the code #287

Merged

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Apr 8, 2023

Description

launcher for autowarefoundation/autoware.universe#3006

Tests performed

See launcher for autowarefoundation/autoware.universe#3006

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@takayuki5168 takayuki5168 force-pushed the refactor/obstacle-cruise-planner branch from 97fdf95 to 92d0316 Compare April 8, 2023 19:48
@takayuki5168 takayuki5168 marked this pull request as ready for review April 10, 2023 07:45
Copy link
Contributor

@purewater0901 purewater0901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 force-pushed the refactor/obstacle-cruise-planner branch from 4f56622 to ead7150 Compare April 11, 2023 04:30
@takayuki5168 takayuki5168 merged commit b1ed636 into autowarefoundation:main Apr 11, 2023
@takayuki5168 takayuki5168 deleted the refactor/obstacle-cruise-planner branch April 11, 2023 08:50
tkimura4 referenced this pull request in tier4/autoware_launch Apr 18, 2023
Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>
takayuki5168 referenced this pull request in tier4/autoware_launch May 21, 2023
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants