Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(rviz-config): use colors consistent with new theme #1169

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

KhalilSelyan
Copy link
Contributor

@KhalilSelyan KhalilSelyan commented Sep 13, 2024

Description

Updated 3d panel bg color and overlays bg colors as well to match the rest of the theme

image

related to

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@KhalilSelyan KhalilSelyan self-assigned this Sep 13, 2024
@github-actions github-actions bot added the component:ui User interface, user experience, graphical user interfaces. (auto-assigned) label Sep 13, 2024
KhalilSelyan and others added 2 commits September 17, 2024 17:59
Signed-off-by: KhalilSelyan <khalil@leodrive.ai>
Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
@xmfcx xmfcx force-pushed the style/use-consistent-bg-colors-with-theme branch from b6389e4 to a63c551 Compare September 17, 2024 14:59
Copy link
Contributor

@xmfcx xmfcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Looks like this with the new changes.

@xmfcx xmfcx merged commit dba8a3e into main Sep 18, 2024
18 checks passed
@xmfcx xmfcx deleted the style/use-consistent-bg-colors-with-theme branch September 18, 2024 09:36
@xmfcx xmfcx changed the title style: use colors consistent with new theme style(rviz-config): use colors consistent with new theme Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:ui User interface, user experience, graphical user interfaces. (auto-assigned) tag:run-build-and-test-differential
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants