feat(autoware_launch): add obstacle_collision_checker to launch #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shmpwk
reviewed
Nov 2, 2022
There was a problem hiding this comment.
Do you think this option is useful for planning_simulator and logging_simultor as well?
Yes I think we should add. Also we should add it into e2e_simulator.launch.xml. I am gonna add the option. Thank you for suggestion 👍🏼 |
Signed-off-by: Berkay Karaman <berkay@leodrive.ai>
Signed-off-by: Berkay Karaman <berkay@leodrive.ai>
brkay54
force-pushed
the
add-occ-launch
branch
from
fa7cedc
to
261c807
Compare
shmpwk
approved these changes
Nov 2, 2022
4 tasks
|
@takayuki5168 @shmpwk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Berkay Karaman berkay@leodrive.ai
Description
This PR about adding obstacle_collision_checker to control.launch.py. This will be optional.
This PR should merge after autowarefoundation/autoware.universe#2193 merged!
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.