Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(control_validator)!: add velocity check #1050

Conversation

yuki-takagi-66
Copy link
Contributor

@yuki-takagi-66 yuki-takagi-66 commented Jul 3, 2024

Description

add velocity check function to validate vehicle velocity controllers

universe: autowarefoundation/autoware.universe#7806

Tests performed

psim and tier4 internal test

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added component:system System design and integration. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) labels Jul 3, 2024
@yuki-takagi-66 yuki-takagi-66 force-pushed the control_validator/add-velocity-check branch from 2d8bb04 to 14d2643 Compare July 4, 2024 04:07
@github-actions github-actions bot removed the component:system System design and integration. (auto-assigned) label Jul 4, 2024
@yuki-takagi-66 yuki-takagi-66 force-pushed the control_validator/add-velocity-check branch from 14d2643 to e14552e Compare July 4, 2024 04:19
@github-actions github-actions bot added the component:system System design and integration. (auto-assigned) label Jul 4, 2024
@yuki-takagi-66 yuki-takagi-66 force-pushed the control_validator/add-velocity-check branch 2 times, most recently from d72dc1a to 8af3834 Compare July 9, 2024 04:33
@github-actions github-actions bot removed the component:system System design and integration. (auto-assigned) label Jul 9, 2024
@yuki-takagi-66 yuki-takagi-66 changed the title feat(control_validator): add velocity check feat(control_validator)!: add velocity check Jul 9, 2024
@yuki-takagi-66 yuki-takagi-66 marked this pull request as ready for review July 9, 2024 04:46
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
@yuki-takagi-66 yuki-takagi-66 force-pushed the control_validator/add-velocity-check branch from 8af3834 to 5db2225 Compare July 17, 2024 11:26
@yuki-takagi-66 yuki-takagi-66 merged commit dbd69d8 into autowarefoundation:main Jul 18, 2024
13 checks passed
@yuki-takagi-66 yuki-takagi-66 deleted the control_validator/add-velocity-check branch July 18, 2024 02:18
yuki-takagi-66 added a commit to tier4/autoware_launch that referenced this pull request Sep 17, 2024
add param

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
yuki-takagi-66 added a commit to tier4/autoware_launch that referenced this pull request Sep 17, 2024
add param

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned) tag:run-build-and-test-differential
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants