Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker): remove latest tag #5201

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

oguzkaganozt
Copy link
Contributor

@oguzkaganozt oguzkaganozt commented Sep 9, 2024

Description

Removal of latest tag from images, instead use it as a stable tag to universe
Fixes #5175

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@oguzkaganozt oguzkaganozt self-assigned this Sep 9, 2024
@oguzkaganozt oguzkaganozt linked an issue Sep 9, 2024 that may be closed by this pull request
5 tasks
@oguzkaganozt oguzkaganozt changed the title remove latest tag fix(docker): remove latest tag Sep 9, 2024
@oguzkaganozt oguzkaganozt force-pushed the 5175-remove-the-latest-keyword-from-docker-tags branch from 3e95642 to 54f5639 Compare September 9, 2024 09:37
@oguzkaganozt
Copy link
Contributor Author

@youtalk please review

Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run the docker-build-and-push CI to check the validity.

@oguzkaganozt oguzkaganozt force-pushed the 5175-remove-the-latest-keyword-from-docker-tags branch from 54f5639 to fb8402f Compare September 9, 2024 12:56
@oguzkaganozt
Copy link
Contributor Author

Please run the docker-build-and-push CI to check the validity.

@youtalk could you review it again

@youtalk
Copy link
Member

youtalk commented Sep 9, 2024

Because you didn't run the workflow, I did it. I will review again when it is done.
https://github.com/autowarefoundation/autoware/actions/runs/10782590530

@youtalk
Copy link
Member

youtalk commented Sep 10, 2024

I've checked the tag names and there are still latest- prefix tags. I think we need to fix them.
Screenshot 2024-09-10 at 13 00 45

Signed-off-by: Oguz Ozturk <oguzkaganozt@gmail.com>
@oguzkaganozt oguzkaganozt force-pushed the 5175-remove-the-latest-keyword-from-docker-tags branch from fb8402f to d512c9d Compare September 10, 2024 08:09
@oguzkaganozt
Copy link
Contributor Author

oguzkaganozt commented Sep 10, 2024

I've checked the tag names and there are still latest- prefix tags. I think we need to fix them. Screenshot 2024-09-10 at 13 00 45

I checked the logs within this run and there were no images exported with latest tag. Maybe those with latest tags came from different workflow runs.

Anyway I just started a new workflow run to double-check it.

@oguzkaganozt
Copy link
Contributor Author

There is no latest- prefix tag pushed into the packages

image

Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your double check. LGTM

@youtalk
Copy link
Member

youtalk commented Sep 11, 2024

@oguzkaganozt By the way, I started to feel that the humble- and 20XXYYZZ- tags should be used as suffixes rather than prefixes. What do you think? If you agree, I would appreciate it if you could proceed with the work after creating the issue.

Here’s the final image I have in mind:

  • Since there are no images for distributions other than humble at the moment, we can temporarily remove the humble- tags.
  • Instead of 20XXYYZZ-universe-cuda, change it to universe-cuda-20XXYYZZ. The same applies to other tags as well.

@oguzkaganozt oguzkaganozt merged commit e56d4c3 into main Sep 11, 2024
18 checks passed
@oguzkaganozt oguzkaganozt deleted the 5175-remove-the-latest-keyword-from-docker-tags branch September 11, 2024 08:51
@oguzkaganozt
Copy link
Contributor Author

oguzkaganozt commented Sep 11, 2024

@youtalk I agree that we should omit the humble tags at least for now. Since we generated lot of different alternative docker images I think we should make tags human-readable as much as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:run-health-check Run health-check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the latest keyword from docker tags
2 participants