Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the latest keyword from docker tags #5175

Closed
3 of 5 tasks
xmfcx opened this issue Sep 5, 2024 · 5 comments · Fixed by #5201
Closed
3 of 5 tasks

Remove the latest keyword from docker tags #5175

xmfcx opened this issue Sep 5, 2024 · 5 comments · Fixed by #5201
Assignees
Labels
component:openadkit Issues or Features related to Open AD Kit type:containers Docker containers, containerization of components, or container orchestration.

Comments

@xmfcx
Copy link
Contributor

xmfcx commented Sep 5, 2024

Checklist

  • I've read the contribution guidelines.
  • I've searched other issues and no duplicate issues were found.
  • I've agreed with the maintainers that I can plan this task.

Description

@youtalk -san, I think the latest keyword is also becoming redundant, what do you think of removing it?
Is there a benefit in keeping the latest keyword?

Before After
autoware:latest-base autoware:base
autoware:latest-core-devel autoware:core-devel
autoware:latest-universe-devel autoware:universe-devel
autoware:latest-devel autoware:devel
autoware:latest-universe autoware:universe

Purpose

To not have redundant keywords in images.

Possible approaches

Definition of done

  • Docker image tags don't have latest keyword anymore.
  • Dependent repos are updated.
@xmfcx xmfcx added the type:containers Docker containers, containerization of components, or container orchestration. label Sep 5, 2024
@youtalk
Copy link
Member

youtalk commented Sep 5, 2024

According to the discussion https://github.com/orgs/autowarefoundation/discussions/4995 I approved.
However I would like to remain the autoware:latest tag to be the same as the autoware:universe tag for a while.

@xmfcx
Copy link
Contributor Author

xmfcx commented Sep 5, 2024

It's alright to have autoware:latest 👍

@oguzkaganozt
Copy link
Contributor

autoware:latest can be good and a needful simplification to users

@youtalk
Copy link
Member

youtalk commented Sep 5, 2024

This is not my emergent issue.
I'm waiting for your contribution not only by discussion but by PR.
Thanks.

@oguzkaganozt oguzkaganozt added the component:openadkit Issues or Features related to Open AD Kit label Sep 6, 2024
@oguzkaganozt oguzkaganozt linked a pull request Sep 9, 2024 that will close this issue
4 tasks
@oguzkaganozt
Copy link
Contributor

Fix PR #5201

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:openadkit Issues or Features related to Open AD Kit type:containers Docker containers, containerization of components, or container orchestration.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants