Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ansible): add yabloc archive extraction to andsible script #3855

Conversation

lexavtanke
Copy link
Contributor

@lexavtanke lexavtanke commented Sep 22, 2023

Description

Add extraction step after downloading artifacts for yabloc_pose_initializer. Otherwise package will not be able to access it's artifacts.

See autowarefoundation/autoware.universe#3137

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>
Copy link
Contributor

@esteve esteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lexavtanke if the package needs the artifacts for compiling, then they must be added to the source tree in the repository. The Debian and ROS buildfarms will not run ansible scripts before building packages.

@lexavtanke
Copy link
Contributor Author

@esteve These files don't used during build time only during runtime. Actually I don't know why there are so many files in the archive because only model_float32.pb is used in launch files. I guess @KYabuuchi can explain more clear.

@KYabuuchi
Copy link

YabLoc does not require the models during compilation. The model_float32.pb is loaded when performing initial pose estimation after launching Autoware.

If the model file is not found, non-DNN methods will be used for initial pose estimation. (This is not accurate, but initial position estimation will complete.)

@esteve
Copy link
Contributor

esteve commented Sep 22, 2023

@lexavtanke ah, I see, thanks for the explanation. LGTM

@esteve esteve merged commit 871f53c into autowarefoundation:main Sep 22, 2023
15 checks passed
@lexavtanke lexavtanke deleted the add-archive-exctraction-for-yabloc-in-ansible branch September 25, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants