Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mission_planner): add option to prevent rerouting in autonomous driving mode #8757

Merged

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Sep 4, 2024

Description

add option to prevent rerouting in autonomous driving mode
set true by default.
if false, reroute fails. if true, only safe reroute is allowed.

Related links

Parent Issue:

  • Link

How was this PR tested?

psim

set false

reroute-2024-09-04_16.28.22.mp4

2024/09/04 https://evaluation.tier4.jp/evaluation/reports/00d52220-01c8-5767-ae65-97fd3f71150c/?project_id=prd_jt

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

…driving mode

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 marked this pull request as ready for review September 4, 2024 07:52
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Sep 4, 2024
Copy link

github-actions bot commented Sep 4, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link
Contributor

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kosuke55 kosuke55 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 11, 2024
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 24.17%. Comparing base (c0e9251) to head (88ba0b5).
Report is 89 commits behind head on main.

Files with missing lines Patch % Lines
...on_planner/src/mission_planner/mission_planner.cpp 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8757      +/-   ##
==========================================
+ Coverage   24.14%   24.17%   +0.03%     
==========================================
  Files        1407     1414       +7     
  Lines      102307   102377      +70     
  Branches    38826    38830       +4     
==========================================
+ Hits        24698    24749      +51     
- Misses      75111    75181      +70     
+ Partials     2498     2447      -51     
Flag Coverage Δ *Carryforward flag
differential 9.45% <0.00%> (?)
total 24.14% <ø> (ø) Carriedforward from c0e9251

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kosuke55 kosuke55 merged commit 86fdd76 into autowarefoundation:main Sep 11, 2024
43 of 44 checks passed
@kosuke55 kosuke55 deleted the feat/block_reroute_autonomous branch September 11, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants