refactor(autoware_pointcloud_preprocessor): rework pickup based voxel grid downsample filter parameters #8481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
github-actions
bot
added
type:documentation
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
vividf
added
the
tag:run-build-and-test-differential
vividf
requested review from
amc-nu,
badai-nguyen,
drwnz,
knzo25,
kyoichi-sugahara,
meliketanrikulu,
miursh,
YoshiRi and
yukkysaito
as code owners
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
vividf
added
the
tag:deploy-docs
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8481 +/- ##
==========================================
- Coverage 28.01% 23.66% -4.35%
==========================================
Files 1319 1417 +98
Lines 98635 103796 +5161
Branches 39789 39856 +67
==========================================
- Hits 27631 24563 -3068
- Misses 70949 76887 +5938
- Partials 55 2346 +2291
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
knzo25
requested changes
Aug 20, 2024
...re_pointcloud_preprocessor/schema/pickup_based_voxel_grid_downsample_filter_node.schema.json
Show resolved
Hide resolved
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
|
@knzo25 kindly ping |
…sample_filter_parameter
knzo25
reviewed
Sep 3, 2024
...re_pointcloud_preprocessor/schema/pickup_based_voxel_grid_downsample_filter_node.schema.json
Outdated
Show resolved
Hide resolved
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
…er_parameter' of github.com:vividf/autoware.universe into refactor/rework_pickup_based_voxel_grid_downsample_filter_parameter
…sample_filter_parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes the following changes
A big thank you to @Ariiees for the PRs (#8297 and #7422), where we worked together on the entire pointcloud preprocessor parameters, launch file, and schema.
Related links
Parent Issue:
How was this PR tested?
ros2 launch autoware_pointcloud_preprocessor pickup_based_voxel_grid_downsample_filter_node.launch.xmlNotes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.