refactor(autoware_pointcloud_preprocessor): rework approximate downsample filter parameters #8480
+81
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
github-actions
bot
added
type:documentation
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
vividf
added
the
tag:run-build-and-test-differential
vividf
requested review from
amc-nu,
badai-nguyen,
drwnz,
knzo25,
kyoichi-sugahara,
meliketanrikulu,
miursh,
YoshiRi and
yukkysaito
as code owners
vividf
added
the
tag:deploy-docs
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8480 +/- ##
==========================================
- Coverage 28.01% 23.74% -4.27%
==========================================
Files 1319 1417 +98
Lines 98635 102019 +3384
Branches 39789 39031 -758
==========================================
- Hits 27631 24224 -3407
- Misses 70949 75487 +4538
- Partials 55 2308 +2253
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
knzo25
reviewed
Aug 20, 2024
sensing/autoware_pointcloud_preprocessor/schema/approximate_downsample_filter_node.schema.json
Outdated
Show resolved
Hide resolved
knzo25
reviewed
Aug 20, 2024
...utoware_pointcloud_preprocessor/src/downsample_filter/approximate_downsample_filter_node.cpp
Outdated
Show resolved
Hide resolved
knzo25
requested changes
Aug 20, 2024
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
vividf
removed request for
beyzanurkaya,
KhalilSelyan,
kosuke55,
zusizusi,
shmpwk,
technolojin,
mitsudome-r,
isamu-takagi,
kminoda,
satoshi-ota,
brkay54,
tzhong518,
Shin-kyoto,
tkimura4,
ktro2828,
taikitanaka3,
maxime-clem,
Motsu-san,
zulfaqar-azmi-t4,
TaikiYamada4,
mkquda and
yuki-takagi-66
|
@knzo25 kindly ping |
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
knzo25
reviewed
Sep 17, 2024
...utoware_pointcloud_preprocessor/src/downsample_filter/approximate_downsample_filter_node.cpp
Show resolved
Hide resolved
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
knzo25
reviewed
Sep 30, 2024
| "type": "number", | ||
| "description": "voxel size along the x-axis [m]", | ||
| "default": "0.3", | ||
| "minimum": 0 |
There was a problem hiding this comment.
As I explained in previous PRs, please keep consistency with the floating representation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes the following changes
nodelettonode.A big thank you to @Ariiees for the PRs (#8297 and #7422), where we worked together on the entire pointcloud preprocessor parameters, launch file, and schema.
Related links
Parent Issue:
How was this PR tested?
ros2 launch autoware_pointcloud_preprocessor approximate_downsample_filter.launch.xmlNotes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.