refactor(autoware_pointcloud_preprocessor): rework ring passthrough filter parameters #8472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
github-actions
bot
added
type:documentation
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
vividf
requested review from
amc-nu,
badai-nguyen,
drwnz,
knzo25,
kyoichi-sugahara,
meliketanrikulu,
miursh,
YoshiRi and
yukkysaito
as code owners
vividf
added
the
tag:run-build-and-test-differential
badai-nguyen
added
the
tag:deploy-docs
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8472 +/- ##
==========================================
- Coverage 25.23% 25.21% -0.02%
==========================================
Files 1325 1330 +5
Lines 98572 98715 +143
Branches 38088 38148 +60
==========================================
+ Hits 24874 24893 +19
- Misses 71156 71272 +116
- Partials 2542 2550 +8
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
amadeuszsz
requested changes
Aug 20, 2024
There was a problem hiding this comment.
Your schema file is not processed because none of config files match:
No configuration files found for schema sensing/autoware_pointcloud_preprocessor/schema/passthrough_filter_uint16_node.schema.json.
FYI, CI takes schema file name without suffix and compare it with all config files in ../config/ directory with name <schema_file_name>*.param.yaml. You could change schema or config name (may affect other packages).
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
|
@amadeuszsz |
|
@badai-nguyen @knzo25 @drwnz This PR needs a maintainer to approve it, thanks! |
knzo25
reviewed
Sep 3, 2024
sensing/autoware_pointcloud_preprocessor/config/passthrough_filter_uint16_node.param.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
emuemuJP
pushed a commit
to arayabrain/autoware.universe.origin
that referenced
this pull request
Sep 10, 2024
…ilter parameters (autowarefoundation#8472) * feat: rework ring passthrough parameters Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix cmake Signed-off-by: vividf <yihsiang.fang@tier4.jp> * feat: add schema Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix readme Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix parameter file name Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: add boundary Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix default parameter Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix default parameter in schema Signed-off-by: vividf <yihsiang.fang@tier4.jp> --------- Signed-off-by: vividf <yihsiang.fang@tier4.jp> Signed-off-by: emuemuJP <k.matsumoto.0807@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes the following changes
nodelettonode.A big thank you to @Ariiees for the PRs (#8297 and #7422), where we worked together on the entire pointcloud preprocessor parameters, launch file, and schema.
Related links
Parent Issue:
How was this PR tested?
ros2 launch autoware_pointcloud_preprocessor ring_passthrough_filter.launch.xmlNotes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.