Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_path_sampler): fix passedByValue #8216

Merged

Conversation

kobayu858
Copy link
Contributor

@kobayu858 kobayu858 commented Jul 26, 2024

Description

This is a fix based on cppcheck passedByValue warnings

planning/sampling_based_planner/autoware_path_sampler/src/utils/trajectory_utils.cpp:62:38: performance: Function parameter 'traj_points' should be passed by const reference. [passedByValue]
  const std::vector<TrajectoryPoint> traj_points, const double interval)
                                     ^

planning/sampling_based_planner/autoware_path_sampler/src/utils/trajectory_utils.cpp:74:38: performance: Function parameter 'traj_points' should be passed by const reference. [passedByValue]
  const std::vector<TrajectoryPoint> traj_points, const double interval)
                                     ^

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jul 26, 2024
@kobayu858 kobayu858 requested a review from veqcc July 26, 2024 07:25
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kobayu858 kobayu858 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 26, 2024
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.24%. Comparing base (96c1601) to head (f1d7020).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8216      +/-   ##
==========================================
- Coverage   29.25%   29.24%   -0.02%     
==========================================
  Files        1600     1606       +6     
  Lines      117735   117780      +45     
  Branches    50703    50704       +1     
==========================================
  Hits        34443    34443              
- Misses      74072    74117      +45     
  Partials     9220     9220              
Flag Coverage Δ *Carryforward flag
differential 12.32% <ø> (?)
total 29.25% <ø> (ø) Carriedforward from 96c1601

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kobayu858 kobayu858 merged commit 95aef0d into autowarefoundation:main Jul 26, 2024
39 checks passed
a-maumau pushed a commit to a-maumau/autoware.universe that referenced this pull request Jul 28, 2024
fix:passedByValue

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
@kobayu858 kobayu858 deleted the fix/cppcheck_passedByValue_pla-29 branch August 13, 2024 06:18
esteve pushed a commit to esteve/autoware.universe that referenced this pull request Aug 13, 2024
fix:passedByValue

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants