Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(autoware_pointcloud_preprocessor): fix cppcheck warnings of functionStatic #8163

Merged
merged 2 commits into from
Aug 6, 2024
+7 −7
Merged

fix(autoware_pointcloud_preprocessor): fix cppcheck warnings of functionStatic #8163

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1c77e7
fix: deal with functionStatic warnings
taisa1 Jul 23, 2024
877461e
Merge branch 'main' into fix_function_static_autoware_pointcloud_prep…
vividf Aug 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions sensing/autoware_pointcloud_preprocessor/src/downsample_filter/robin_hood.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -567,7 +567,7 @@ template <typename T, size_t MinSize, size_t MaxSize>
struct NodeAllocator<T, MinSize, MaxSize, true>
{
// we are not using the data, so just free it.
void addOrFree(void * ptr, size_t ROBIN_HOOD_UNUSED(numBytes) /*unused*/) noexcept
static void addOrFree(void * ptr, size_t ROBIN_HOOD_UNUSED(numBytes) /*unused*/) noexcept
{
ROBIN_HOOD_LOG("std::free")
std::free(ptr);
Expand Down Expand Up @@ -1051,8 +1051,8 @@ class Table
}

// doesn't do anything
void destroy(M & ROBIN_HOOD_UNUSED(map) /*unused*/) noexcept {}
void destroyDoNotDeallocate() noexcept {}
static void destroy(M & ROBIN_HOOD_UNUSED(map) /*unused*/) noexcept {}
static void destroyDoNotDeallocate() noexcept {}

value_type const * operator->() const noexcept { return &mData; }
value_type * operator->() noexcept { return &mData; }
Expand Down Expand Up @@ -1262,15 +1262,15 @@ class Table
template <typename M>
struct Destroyer<M, true>
{
void nodes(M & m) const noexcept { m.mNumElements = 0; }
static void nodes(M & m) noexcept { m.mNumElements = 0; }

void nodesDoNotDeallocate(M & m) const noexcept { m.mNumElements = 0; }
static void nodesDoNotDeallocate(M & m) noexcept { m.mNumElements = 0; }
};

template <typename M>
struct Destroyer<M, false>
{
void nodes(M & m) const noexcept
static void nodes(M & m) noexcept
{
m.mNumElements = 0;
// clear also resets mInfo to 0, that's sometimes not necessary.
Expand All @@ -1285,7 +1285,7 @@ class Table
}
}

void nodesDoNotDeallocate(M & m) const noexcept
static void nodesDoNotDeallocate(M & m) noexcept
{
m.mNumElements = 0;
// clear also resets mInfo to 0, that's sometimes not necessary.
Expand Down
Loading