Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_behavior_velocity_no_drivable_lane_module): fix bug of uninitialization #7928

Conversation

yhisaki
Copy link
Contributor

@yhisaki yhisaki commented Jul 10, 2024

Description

Fix errors found by using clang

  // size_t target_point_idx; <= uninitilized
  size_t target_point_idx = 0;
  if (op_target_point_idx) {
    target_point_idx = op_target_point_idx.value();
  }
  geometry_msgs::msg::Point stop_point =
    autoware::universe_utils::getPoint(path->points.at(target_point_idx).point);

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

…ninitialization

Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jul 10, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@yhisaki yhisaki added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 10, 2024
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.43%. Comparing base (3d849e9) to head (48eaf6c).
Report is 677 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #7928       +/-   ##
===========================================
+ Coverage   15.09%   28.43%   +13.34%     
===========================================
  Files        1967     1597      -370     
  Lines      135941   116265    -19676     
  Branches    42122    49615     +7493     
===========================================
+ Hits        20520    33060    +12540     
+ Misses      92700    74183    -18517     
+ Partials    22721     9022    -13699     
Flag Coverage Δ *Carryforward flag
differential 13.39% <ø> (?)
total 28.44% <ø> (+13.35%) ⬆️ Carriedforward from 1cbd11d

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yhisaki yhisaki enabled auto-merge (squash) July 10, 2024 04:06
@yhisaki yhisaki merged commit a39cfb7 into autowarefoundation:main Jul 10, 2024
40 of 41 checks passed
Ariiees pushed a commit to Ariiees/autoware.universe that referenced this pull request Jul 22, 2024
…ninitialization (autowarefoundation#7928)

Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants