Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(surround_obstacle_checker): use polling subscriber #7215

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Jun 1, 2024

Description

The same as this PR based on the discussion, the polling subscriber is used in the obstacle_avoidance_planner.

Tests performed

psim

Effects on system behavior

Nothing but more efficient CPU usage

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jun 1, 2024
@takayuki5168 takayuki5168 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 1, 2024
Copy link

codecov bot commented Jun 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (3d849e9) to head (49403f3).
Report is 150 commits behind head on main.

Files Patch % Lines
planning/surround_obstacle_checker/src/node.cpp 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #7215       +/-   ##
==========================================
- Coverage   15.09%   0.00%   -15.10%     
==========================================
  Files        1967       2     -1965     
  Lines      135941     337   -135604     
  Branches    42122       0    -42122     
==========================================
- Hits        20520       0    -20520     
+ Misses      92700     337    -92363     
+ Partials    22721       0    -22721     
Flag Coverage Δ
differential 0.00% <0.00%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 force-pushed the feat/use-polling-subscriber-surround-obstacle branch from f9a7366 to 49403f3 Compare June 5, 2024 15:22
@takayuki5168 takayuki5168 marked this pull request as ready for review June 5, 2024 15:22
@takayuki5168
Copy link
Contributor Author

@satoshi-ota
Can you review the PR?

@satoshi-ota satoshi-ota self-assigned this Jun 6, 2024
@satoshi-ota satoshi-ota merged commit 445b6ae into autowarefoundation:main Jun 6, 2024
27 of 32 checks passed
@satoshi-ota satoshi-ota deleted the feat/use-polling-subscriber-surround-obstacle branch June 6, 2024 05:12
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Jun 6, 2024
…dation#7215)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants