feat(yabloc_image_processing): componentize yabloc_image_processing nodes #7196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
…uchi/autoware.universe into feat/glog_yabloc_image_processsing
KYabuuchi
requested review from
anhnv3991,
Motsu-san,
RyuYamamoto,
SakodaShintaro,
TaikiYamada4 and
YamatoAndo
as code owners
KYabuuchi
added
the
tag:run-build-and-test-differential
github-actions
bot
added
the
component:localization
SakodaShintaro
approved these changes
Jun 5, 2024
danielsanchezaran
pushed a commit
that referenced
this pull request
Jun 6, 2024
…odes (#7196) * replace executable with component Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * modify launch Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * fix line_segments_overlay namespace & node_name Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * style(pre-commit): autofix * uncomment lanelet2_overlay Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> --------- Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
kminoda
pushed a commit
to kminoda/autoware.universe
that referenced
this pull request
Jun 6, 2024
…odes (autowarefoundation#7196) * replace executable with component Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * modify launch Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * fix line_segments_overlay namespace & node_name Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * style(pre-commit): autofix * uncomment lanelet2_overlay Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> --------- Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
a-maumau
pushed a commit
to a-maumau/autoware.universe
that referenced
this pull request
Jun 7, 2024
…odes (autowarefoundation#7196) * replace executable with component Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * modify launch Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * fix line_segments_overlay namespace & node_name Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * style(pre-commit): autofix * uncomment lanelet2_overlay Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> --------- Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
…odes (#7196) * replace executable with component Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * modify launch Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * fix line_segments_overlay namespace & node_name Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * style(pre-commit): autofix * uncomment lanelet2_overlay Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> --------- Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
yabloc_image_processing has 6 executable nodes.
I made the following changes to them
Tests performed
1. Confirmed that yabloc works as conventional in logging_simulator
2. Confirmed that terminating the nodes process will output logs to both the terminal and the launch.log.
( The glog is printed only when using rclcpp_component customized by tier4. )
Effects on system behavior
The system behavior does not change.
Interface changes
The interface does not change.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.