refactor(surround_obstacle_checker): rework parameters #5648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com>
github-actions
bot
added
type:documentation
satoshi-ota
added
the
tag:run-build-and-test-differential
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5648 +/- ##
==========================================
+ Coverage 15.32% 15.35% +0.02%
==========================================
Files 1721 1721
Lines 118559 118282 -277
Branches 37995 37880 -115
==========================================
- Hits 18169 18160 -9
+ Misses 79657 79398 -259
+ Partials 20733 20724 -9
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
PhoebeWu21
deleted the
refactor-node-config-surround_obstacle_checker
branch
danielsanchezaran
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Dec 15, 2023
…ation#5648) * refactor(surround_obstacle_checker): rework parameters Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com> * style(pre-commit): autofix --------- Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement the ROS Node configuration layout described in https://github.com/orgs/autowarefoundation/discussions/3371 for the
surround_obstacle_checkerpackage.Tests performed
Package successfully build locally.
colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release --packages-up-to surround_obstacle_checkerEffects on system behavior
More reliable and faster parameter configuration file creation.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.