Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(out_of_lane): prevent "Same points are given" error message #5643

Merged

Conversation

maxime-clem
Copy link
Contributor

Description

Preprocess predicted paths used by the out_of_lane module to prevent the "Same points are given" error message.

Tests performed

Psim

Effects on system behavior

Less error messages.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Nov 21, 2023
@maxime-clem maxime-clem added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 21, 2023
@maxime-clem maxime-clem enabled auto-merge (squash) November 21, 2023 11:32
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 118 lines in your changes are missing coverage. Please review.

Comparison is base (765a596) 15.32% compared to head (0dd2ff1) 21.87%.
Report is 36 commits behind head on main.

Files Patch % Lines
...behavior_velocity_out_of_lane_module/src/debug.cpp 11.66% 44 Missing and 9 partials ⚠️
...ocity_out_of_lane_module/src/scene_out_of_lane.cpp 15.00% 15 Missing and 19 partials ⚠️
...vior_velocity_out_of_lane_module/src/decisions.cpp 0.00% 9 Missing ⚠️
...t_of_lane_module/src/calculate_slowdown_points.hpp 0.00% 7 Missing ⚠️
...ocity_out_of_lane_module/src/overlapping_range.cpp 0.00% 5 Missing ⚠️
...behavior_velocity_out_of_lane_module/src/types.hpp 61.53% 3 Missing and 2 partials ⚠️
...ut_of_lane_module/src/filter_predicted_objects.hpp 0.00% 3 Missing ⚠️
...havior_velocity_out_of_lane_module/src/manager.cpp 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5643       +/-   ##
===========================================
+ Coverage   15.32%   21.87%    +6.55%     
===========================================
  Files        1721       15     -1706     
  Lines      118559      992   -117567     
  Branches    37995      553    -37442     
===========================================
- Hits        18169      217    -17952     
+ Misses      79657      473    -79184     
+ Partials    20733      302    -20431     
Flag Coverage Δ
differential 21.87% <15.10%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxime-clem maxime-clem merged commit 3d3086c into autowarefoundation:main Nov 21, 2023
32 of 33 checks passed
@maxime-clem maxime-clem deleted the out_of_lane/no-error-msg branch November 21, 2023 12:25
takayuki5168 pushed a commit to tier4/autoware.universe that referenced this pull request Nov 22, 2023
danielsanchezaran pushed a commit to tier4/autoware.universe that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants