-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(start_planner): fix logPullOutStatus format specifier #5637
Merged
kyoichi-sugahara
merged 2 commits into
autowarefoundation:main
from
kyoichi-sugahara:fix/debug_print_start_planner
Nov 21, 2023
Merged
fix(start_planner): fix logPullOutStatus format specifier #5637
kyoichi-sugahara
merged 2 commits into
autowarefoundation:main
from
kyoichi-sugahara:fix/debug_print_start_planner
Nov 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
kyoichi-sugahara
requested review from
rej55,
kosuke55,
satoshi-ota,
shmpwk,
taikitanaka3,
TakaHoribe,
takayuki5168,
tkimura4,
purewater0901 and
zulfaqar-azmi-t4
as code owners
November 21, 2023 02:24
github-actions
bot
added
the
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
label
Nov 21, 2023
kyoichi-sugahara
added
the
tag:run-build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Nov 21, 2023
kosuke55
approved these changes
Nov 21, 2023
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
kyoichi-sugahara
merged commit Nov 21, 2023
88c1e72
into
autowarefoundation:main
22 of 24 checks passed
takayuki5168
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Nov 22, 2023
…undation#5637) * Fix logFunc format specifier in StartPlannerModule Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> --------- Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
danielsanchezaran
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Dec 15, 2023
…undation#5637) * Fix logFunc format specifier in StartPlannerModule Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> --------- Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
tag:run-build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The undefined behavior caused by passing a temporary object as an argument to a function was resolved by storing the temporary object in a std::string variable, thereby ensuring an appropriate lifespan.
Tests performed
confrimed in psim and scenario evaluator.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.