Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(start_planner): fix logPullOutStatus format specifier #5637

Conversation

kyoichi-sugahara
Copy link
Contributor

Description

The undefined behavior caused by passing a temporary object as an argument to a function was resolved by storing the temporary object in a std::string variable, thereby ensuring an appropriate lifespan.

Tests performed

confrimed in psim and scenario evaluator.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Nov 21, 2023
@kyoichi-sugahara kyoichi-sugahara added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 21, 2023
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
@kyoichi-sugahara kyoichi-sugahara enabled auto-merge (squash) November 21, 2023 02:51
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 1042 lines in your changes are missing coverage. Please review.

Comparison is base (765a596) 15.32% compared to head (c1a9555) 12.63%.
Report is 34 commits behind head on main.

Files Patch % Lines
...s/drivable_area_expansion/static_drivable_area.cpp 11.54% 623 Missing and 74 partials ⚠️
.../scene_module/goal_planner/goal_planner_module.cpp 1.48% 132 Missing and 1 partial ⚠️
...cene_module/start_planner/start_planner_module.cpp 7.40% 50 Missing ⚠️
planning/behavior_path_planner/src/utils/utils.cpp 35.89% 31 Missing and 19 partials ⚠️
...er/src/scene_module/avoidance/avoidance_module.cpp 0.00% 34 Missing and 2 partials ⚠️
...ing/behavior_path_planner/src/utils/path_utils.cpp 42.30% 0 Missing and 30 partials ⚠️
.../scene_module/goal_planner/goal_planner_module.hpp 15.78% 15 Missing and 1 partial ⚠️
...th_planner/src/scene_module/lane_change/normal.cpp 0.00% 13 Missing ⚠️
...e/behavior_path_planner/utils/avoidance/helper.hpp 0.00% 4 Missing ⚠️
...ath_planner/src/scene_module/avoidance/manager.cpp 0.00% 0 Missing and 4 partials ⚠️
... and 5 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5637       +/-   ##
===========================================
- Coverage   15.32%   12.63%    -2.69%     
===========================================
  Files        1721      107     -1614     
  Lines      118559    14981   -103578     
  Branches    37995     8421    -29574     
===========================================
- Hits        18169     1893    -16276     
+ Misses      79657    10140    -69517     
+ Partials    20733     2948    -17785     
Flag Coverage Δ
differential 12.63% <12.94%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kyoichi-sugahara kyoichi-sugahara merged commit 88c1e72 into autowarefoundation:main Nov 21, 2023
22 of 24 checks passed
@kyoichi-sugahara kyoichi-sugahara deleted the fix/debug_print_start_planner branch November 21, 2023 04:23
takayuki5168 pushed a commit to tier4/autoware.universe that referenced this pull request Nov 22, 2023
…undation#5637)

* Fix logFunc format specifier in StartPlannerModule

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

---------

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
danielsanchezaran pushed a commit to tier4/autoware.universe that referenced this pull request Dec 15, 2023
…undation#5637)

* Fix logFunc format specifier in StartPlannerModule

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

---------

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants