Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(image_projection_based_fusion): fix document #5625

Conversation

badai-nguyen
Copy link
Contributor

Description

To solve #5607

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) labels Nov 20, 2023
@badai-nguyen badai-nguyen marked this pull request as ready for review November 20, 2023 00:54
@badai-nguyen badai-nguyen added the tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) label Nov 20, 2023
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
@badai-nguyen badai-nguyen added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 20, 2023
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (765a596) 15.32% compared to head (552f891) 15.32%.
Report is 26 commits behind head on main.

Files Patch % Lines
...rivable_area_expansion/drivable_area_expansion.cpp 40.00% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5625      +/-   ##
==========================================
- Coverage   15.32%   15.32%   -0.01%     
==========================================
  Files        1721     1726       +5     
  Lines      118559   118515      -44     
  Branches    37995    37879     -116     
==========================================
- Hits        18169    18160       -9     
+ Misses      79657    79631      -26     
+ Partials    20733    20724       -9     
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 15.35% <40.00%> (+0.02%) ⬆️ Carriedforward from 017aed4

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@badai-nguyen badai-nguyen merged commit a9d05d5 into autowarefoundation:main Nov 22, 2023
32 of 33 checks passed
@badai-nguyen badai-nguyen deleted the fix/image_projection_based_fusion_document branch November 22, 2023 03:23
danielsanchezaran pushed a commit to tier4/autoware.universe that referenced this pull request Dec 15, 2023
…n#5625)

* chore(image_projection_based_fusion): fix document

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* chore: add maintainers

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

---------

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants