Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(out_of_lane): improve reuse of previous decision #5611

Conversation

maxime-clem
Copy link
Contributor

@maxime-clem maxime-clem commented Nov 16, 2023

Description

Improve the reuse of the previous decision in the out_of_lane module, avoiding bugs when the path changes suddenly.

Tests performed

Psim
Evaluator (TIER IV INTERNAL LINK): https://evaluation.tier4.jp/evaluation/reports/c2665660-1e2f-5aca-8a75-54820dd34155?project_id=prd_jt

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Nov 16, 2023
@maxime-clem maxime-clem changed the title feat(out_of_lane): improve reuse of previous decision feat(out_of_lane): improve reuse of previous decision Nov 16, 2023
@maxime-clem maxime-clem added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 16, 2023
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 118 lines in your changes are missing coverage. Please review.

Comparison is base (765a596) 15.32% compared to head (98a30ab) 15.35%.
Report is 18 commits behind head on main.

Files Patch % Lines
...behavior_velocity_out_of_lane_module/src/debug.cpp 11.66% 44 Missing and 9 partials ⚠️
...ocity_out_of_lane_module/src/scene_out_of_lane.cpp 15.00% 15 Missing and 19 partials ⚠️
...vior_velocity_out_of_lane_module/src/decisions.cpp 0.00% 9 Missing ⚠️
...t_of_lane_module/src/calculate_slowdown_points.hpp 0.00% 7 Missing ⚠️
...ocity_out_of_lane_module/src/overlapping_range.cpp 0.00% 5 Missing ⚠️
...behavior_velocity_out_of_lane_module/src/types.hpp 61.53% 3 Missing and 2 partials ⚠️
...rivable_area_expansion/drivable_area_expansion.cpp 40.00% 0 Missing and 3 partials ⚠️
...havior_velocity_out_of_lane_module/src/manager.cpp 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5611      +/-   ##
==========================================
+ Coverage   15.32%   15.35%   +0.02%     
==========================================
  Files        1721     1721              
  Lines      118559   118488      -71     
  Branches    37995    38001       +6     
==========================================
+ Hits        18169    18188      +19     
+ Misses      79657    79542     -115     
- Partials    20733    20758      +25     
Flag Coverage Δ *Carryforward flag
differential 21.91% <15.44%> (?)
total 15.34% <40.00%> (+0.02%) ⬆️ Carriedforward from 017aed4

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxime-clem maxime-clem marked this pull request as ready for review November 16, 2023 13:18
@maxime-clem maxime-clem merged commit db74641 into autowarefoundation:main Nov 16, 2023
35 of 37 checks passed
@maxime-clem maxime-clem deleted the feat/out_of_lane-project_reused_stop_point-universe branch November 16, 2023 23:26
takayuki5168 pushed a commit to tier4/autoware.universe that referenced this pull request Nov 22, 2023
…tion#5611)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants