Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(radar_object_tracker): change to use use_radar_tracking_fusion as true #5605

Merged

Conversation

miursh
Copy link
Contributor

@miursh miursh commented Nov 16, 2023

Set default parameter use_radar_tracking_fusion to true

Description

Tests performed

By logging simulator.launch with perception_mode:=camera_lidar_radar_fusion option

  • Confirmed that /perception/object_recognition/tracking/radar_object_tracker has been launched
  • The topic names are connected as intended.
    image

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

… as true

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
@github-actions github-actions bot added the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Nov 16, 2023
@miursh miursh requested a review from kminoda November 16, 2023 04:28
Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@miursh miursh enabled auto-merge (squash) November 16, 2023 06:11
@miursh miursh changed the title feat(radar_object_tracker): Change to use use_radar_tracking_fusion as true feat(radar_object_tracker): Change to use use_radar_tracking_fusion as true Nov 16, 2023
@miursh miursh changed the title feat(radar_object_tracker): Change to use use_radar_tracking_fusion as true feat(radar_object_tracker): change to use use_radar_tracking_fusion as true Nov 16, 2023
@miursh miursh added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 16, 2023
@miursh miursh merged commit 931c574 into autowarefoundation:main Nov 16, 2023
27 checks passed
@miursh miursh deleted the feat/change_radar_tracker_option branch November 16, 2023 10:42
takayuki5168 pushed a commit to tier4/autoware.universe that referenced this pull request Nov 22, 2023
… as true (autowarefoundation#5605)

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants