Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(avoidance): fix avoidance exit condition #5592

Merged

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Nov 15, 2023

Description

Keep RUNNING state while the ego is on the shift line.

simplescreenrecorder-2023-11-16_12.13.55.mp4

Tests performed

simplescreenrecorder-2023-11-16_12.19.09.mp4

Effects on system behavior

Return original path more smoothly.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Nov 15, 2023
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota satoshi-ota marked this pull request as ready for review November 16, 2023 03:27
@satoshi-ota satoshi-ota added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 16, 2023
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 60 lines in your changes are missing coverage. Please review.

Comparison is base (765a596) 15.32% compared to head (6dddb22) 15.33%.
Report is 11 commits behind head on main.

Files Patch % Lines
.../scene_module/goal_planner/goal_planner_module.cpp 2.50% 39 Missing ⚠️
.../scene_module/goal_planner/goal_planner_module.hpp 0.00% 15 Missing ⚠️
...er/src/scene_module/avoidance/avoidance_module.cpp 0.00% 3 Missing ⚠️
...rivable_area_expansion/drivable_area_expansion.cpp 40.00% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5592   +/-   ##
=======================================
  Coverage   15.32%   15.33%           
=======================================
  Files        1721     1721           
  Lines      118559   118509   -50     
  Branches    37995    37997    +2     
=======================================
+ Hits        18169    18170    +1     
+ Misses      79657    79600   -57     
- Partials    20733    20739    +6     
Flag Coverage Δ *Carryforward flag
differential 12.70% <4.76%> (?)
total 15.33% <40.00%> (+0.01%) ⬆️ Carriedforward from 017aed4

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@rej55 rej55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satoshi-ota satoshi-ota merged commit 854319e into autowarefoundation:main Nov 16, 2023
32 of 35 checks passed
@satoshi-ota satoshi-ota deleted the fix/avoidance-exit-condition branch November 16, 2023 06:15
satoshi-ota added a commit to satoshi-ota/autoware.universe that referenced this pull request Nov 21, 2023
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
takayuki5168 pushed a commit to tier4/autoware.universe that referenced this pull request Nov 22, 2023
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants