Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(intersection): rename param, update doc #5566

Merged
merged 12 commits into from
Dec 1, 2023
Merged

refactor(intersection): rename param, update doc #5566

merged 12 commits into from
Dec 1, 2023

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Nov 13, 2023

Description

renamed parameter and updated the document to current feature

Tests performed

none.

Effects on system behavior

none.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Nov 13, 2023
@soblin soblin added tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) and removed type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Nov 13, 2023
@github-actions GitHub Actions
Copy link

Documentation URL: https://autowarefoundation.github.io/autoware.universe/pr-5566/
Modified URLs:

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Nov 13, 2023
@soblin soblin force-pushed the refactor/intersection-var-name branch 4 times, most recently from cbdad5a to e442c1b Compare November 14, 2023 06:04
@soblin soblin marked this pull request as ready for review November 14, 2023 06:07
@soblin soblin force-pushed the refactor/intersection-var-name branch 2 times, most recently from d75897f to c7b2abd Compare November 14, 2023 13:49
@soblin
refactor(intersection): rename param, update doc
39ee565 
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@soblin
update doc
44c1aaa 
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@soblin soblin force-pushed the refactor/intersection-var-name branch from c7b2abd to b3382c1 Compare November 14, 2023 13:50
@soblin
update param table
30e53bc 
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@soblin soblin force-pushed the refactor/intersection-var-name branch from b3382c1 to 30e53bc Compare November 14, 2023 13:53
@soblin
added state diagram
2ba2a43 
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@soblin soblin force-pushed the refactor/intersection-var-name branch from c03a8b7 to 2ba2a43 Compare November 16, 2023 07:17
@kyoichi-sugahara kyoichi-sugahara self-assigned this Nov 16, 2023
@soblin
define in-phase anti-phase signal group
db28c38 
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@soblin soblin force-pushed the refactor/intersection-var-name branch from 84721f9 to db28c38 Compare November 17, 2023 05:32
kyoichi-sugahara
kyoichi-sugahara approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!!!

@soblin
fix typo
a07a3d9 
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@soblin
add trouble shooting
4996159 
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@soblin
add trouble shooting for occlusion
f582888 
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@soblin soblin added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 27, 2023
@soblin
fix typo
ee0bf88 
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@soblin soblin force-pushed the refactor/intersection-var-name branch from 811fc1a to ee0bf88 Compare November 27, 2023 04:10
@soblin soblin mentioned this pull request Nov 27, 2023
Merged
7 tasks
@codecov Codecov
Copy link

codecov bot commented Nov 27, 2023 •
edited
Loading

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (765a596) 15.32% compared to head (ba3aad0) 15.28%.
Report is 127 commits behind head on main.

Files Patch % Lines
.../scene_module/goal_planner/goal_planner_module.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5566      +/-   ##
==========================================
- Coverage   15.32%   15.28%   -0.05%     
==========================================
  Files        1721     1717       -4     
  Lines      118559   117042    -1517     
  Branches    37995    37442     -553     
==========================================
- Hits        18169    17886     -283     
+ Misses      79657    78595    -1062     
+ Partials    20733    20561     -172
Flag Coverage Δ *Carryforward flag
differential 5.40% <ø> (?)
total 15.37% <0.00%> (+0.04%) ⬆️ Carriedforward from ee0bf88

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soblin soblin added tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Dec 1, 2023
@soblin soblin added tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Dec 1, 2023
@soblin
add explanation of pass judge
ba3aad0 
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@soblin soblin merged commit beb993e into autowarefoundation:main Dec 1, 2023
19 of 25 checks passed
@soblin soblin deleted the refactor/intersection-var-name branch December 1, 2023 20:26
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Dec 6, 2023
Merged
danielsanchezaran pushed a commit to tier4/autoware.universe that referenced this pull request Dec 15, 2023
@soblin @danielsanchezaran
refactor(intersection): rename param, update doc (autowarefoundation#…
c42aed6 
…5566)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
@soblin @karishma1911
refactor(intersection): rename param, update doc (autowarefoundation#…
d9799cf 
…5566)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: karishma <karishma@interpl.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyoichi-sugahara kyoichi-sugahara kyoichi-sugahara approved these changes

@shmpwk shmpwk Awaiting requested review from shmpwk

@takayuki5168 takayuki5168 Awaiting requested review from takayuki5168

@tkimura4 tkimura4 Awaiting requested review from tkimura4

Assignees

@kyoichi-sugahara kyoichi-sugahara

Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soblin @kyoichi-sugahara