docs(lane_change): stopping position when an object exists ahead #5523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55
requested review from
rej55,
kyoichi-sugahara,
satoshi-ota,
shmpwk,
taikitanaka3,
TakaHoribe,
takayuki5168,
tkimura4,
purewater0901 and
zulfaqar-azmi-t4
as code owners
github-actions
bot
added
type:documentation
kosuke55
changed the title
zulfaqar-azmi-t4
added
the
tag:deploy-docs
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
|
@rej55 |
rej55
added
the
tag:run-build-and-test-differential
|
@TakaHoribe |
TakaHoribe
approved these changes
Nov 13, 2023
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55
force-pushed
the
docs/lane_change_stop_distance
branch
from
dd91379
to
25bc279
Compare
fixed in 25bc279 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5523 +/- ##
==========================================
- Coverage 14.86% 14.83% -0.03%
==========================================
Files 1666 1667 +1
Lines 116258 119302 +3044
Branches 36266 38459 +2193
==========================================
+ Hits 17277 17700 +423
- Misses 79476 81472 +1996
- Partials 19505 20130 +625
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
takayuki5168
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Nov 22, 2023
…owarefoundation#5523) * docs(lane_change): Stopping position when an object exists ahead Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * add stuck params Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * add backward_length_buffer_for_blocking_object Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * add stop for lane change Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> --------- Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
(Currently, due to a bug, it does not actually work as described in the following document, but it does show the ideal behavior.)
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.