feat(behavior_path_planner): add option to insert zero velocity to the center line path #5517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyoichi-sugahara
requested review from
rej55,
kosuke55,
satoshi-ota,
shmpwk,
taikitanaka3,
TakaHoribe,
takayuki5168,
tkimura4,
purewater0901 and
zulfaqar-azmi-t4
as code owners
github-actions
bot
added
the
component:planning
kyoichi-sugahara
force-pushed
the
feat/insert_zero_velocity_center_line_path
branch
from
24bfc29
to
ad1bd6b
Compare
kyoichi-sugahara
changed the title
…e center line path This commit adds a new boolean parameter, `insert_zero_velocity`, to the `getCenterLinePath` function in the `utils.hpp` file. When set to `true`, this parameter will insert a zero velocity to each point in the path. In the `utils.cpp` file, this option is used to insert zero velocities to the reference path generated in the `createGoalAroundPath` function. Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
kyoichi-sugahara
force-pushed
the
feat/insert_zero_velocity_center_line_path
branch
from
ad1bd6b
to
a03b385
Compare
kyoichi-sugahara
added
the
tag:run-build-and-test-differential
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5517 +/- ##
=======================================
Coverage 14.77% 14.77%
=======================================
Files 1684 1684
Lines 116849 116851 +2
Branches 36269 36270 +1
=======================================
+ Hits 17260 17263 +3
+ Misses 80097 80093 -4
- Partials 19492 19495 +3
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
rej55
approved these changes
Nov 8, 2023
kyoichi-sugahara
merged commit 27f61b0
into
autowarefoundation:main
32 of 33 checks passed
kyoichi-sugahara
deleted the
feat/insert_zero_velocity_center_line_path
branch
kminoda
pushed a commit
to kminoda/autoware.universe
that referenced
this pull request
Nov 9, 2023
…e center line path (autowarefoundation#5517) feat(behavior_path_planner): Add option to insert zero velocity to the center line path This commit adds a new boolean parameter, `insert_zero_velocity`, to the `getCenterLinePath` function in the `utils.hpp` file. When set to `true`, this parameter will insert a zero velocity to each point in the path. In the `utils.cpp` file, this option is used to insert zero velocities to the reference path generated in the `createGoalAroundPath` function. Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
takayuki5168
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Nov 22, 2023
…e center line path (autowarefoundation#5517) feat(behavior_path_planner): Add option to insert zero velocity to the center line path This commit adds a new boolean parameter, `insert_zero_velocity`, to the `getCenterLinePath` function in the `utils.hpp` file. When set to `true`, this parameter will insert a zero velocity to each point in the path. In the `utils.cpp` file, this option is used to insert zero velocities to the reference path generated in the `createGoalAroundPath` function. Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit adds a new boolean parameter,
insert_zero_velocity, to thegetCenterLinePathfunction in theutils.hppfile. When set totrue, this parameter will insert a zero velocity to each point in the path. In theutils.cppfile, this option is used to insert zero velocities to the reference path generated in thecreateGoalAroundPathfunction.Tests performed
get the following the output with
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.