Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_velocity_run_out): ignore momentary detection caused by false positive #5359

Conversation

TomohitoAndo
Copy link
Contributor

@TomohitoAndo TomohitoAndo commented Oct 20, 2023

Description

The current 'run_out' module occasionally inserts unnecessary stop points due to false positives in perception.
To prevent this, I have added a feature that ignores any detection lasting less than a specified duration.

This feature can be toggled on or off using the enable parameter.

      # prevent abrupt stops caused by false positives in perception
      ignore_momentary_detection:
        enable: true
        time_threshold: 0.15  # [sec] ignores detections that persist for less than this 

PR for the launch:
autowarefoundation/autoware_launch#647

Related Jira:
TIER IV INTERNAL

Tests performed

Tested on simple planning simulator.

Before

before.mp4

After

after.mp4

Effects on system behavior

None.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

… false positive

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
@TomohitoAndo TomohitoAndo added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 20, 2023
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Oct 20, 2023
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (84995ec) 14.84% compared to head (db5d0da) 14.83%.
Report is 98 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5359      +/-   ##
==========================================
- Coverage   14.84%   14.83%   -0.01%     
==========================================
  Files        1649     1649              
  Lines      114166   114181      +15     
  Branches    35323    35323              
==========================================
  Hits        16943    16943              
- Misses      78102    78117      +15     
  Partials    19121    19121              
Flag Coverage Δ *Carryforward flag
differential 6.79% <0.00%> (?)
total 14.84% <ø> (ø) Carriedforward from 84995ec

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...ing/behavior_velocity_run_out_module/src/utils.hpp 0.00% <ø> (ø)
...g/behavior_velocity_run_out_module/src/manager.cpp 0.00% <0.00%> (ø)
...ing/behavior_velocity_run_out_module/src/scene.cpp 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TomohitoAndo TomohitoAndo merged commit 763a9b8 into autowarefoundation:main Oct 24, 2023
23 of 27 checks passed
takayuki5168 pushed a commit to tier4/autoware.universe that referenced this pull request Oct 25, 2023
… false positive (autowarefoundation#5359)

* feat(behavior_velocity_run_out): ignore momentary detection caused by false positive

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
takayuki5168 pushed a commit to tier4/autoware.universe that referenced this pull request Oct 25, 2023
… false positive (autowarefoundation#5359)

* feat(behavior_velocity_run_out): ignore momentary detection caused by false positive

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
takayuki5168 added a commit to tier4/autoware.universe that referenced this pull request Oct 31, 2023
#991)

feat(behavior_velocity_run_out): ignore momentary detection caused by false positive (autowarefoundation#5359)

* feat(behavior_velocity_run_out): ignore momentary detection caused by false positive



* style(pre-commit): autofix

---------

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Co-authored-by: Tomohito ANDO <tomohito.ando@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@TomohitoAndo TomohitoAndo deleted the feat/run-out-ignore-momentary-detection branch September 14, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants