Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(intersection)!: disable the exception behavior in the private areas #5229

Conversation

yuki-takagi-66
Copy link
Contributor

@yuki-takagi-66 yuki-takagi-66 commented Oct 5, 2023

Description

This PR contains two objectives

  1. make configurable to enable/disable the exception behavior in the private areas.
  2. change the exception behavior in the private area. BEFORE: If the ego are stopping by a stuck object for a several time duration, then the intersection module cancel the stopping. AFTER: If it is enabled by the launch parameters, the intersection module disregard the stuck objects.

Related links

Related PR for launch setting
autowarefoundation/autoware_launch#622

Tests performed

psim test was performed.
disabled
image

enabled
image

  • Tier4 internal test is in performed in success

https://evaluation.tier4.jp/evaluation/reports/fd946252-3247-50f5-9a70-128092c8a5c6?project_id=prd_jt
https://star4.slack.com/archives/C03QW0GU6P7/p1696496558303159

Notes for reviewers

Nothing

Interface changes

New enable/disable parameter is added

Effects on system behavior

No longer behave exceptionally on private area.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

…cle in the private areas

feat: change behavior in the private areas

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Oct 5, 2023
@yuki-takagi-66 yuki-takagi-66 added component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Oct 5, 2023
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
@yuki-takagi-66 yuki-takagi-66 changed the title feat(intersection): disable the exception behavior in the private areas feat(intersection)!: disable the exception behavior in the private areas Oct 5, 2023
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (5fed746) 14.79% compared to head (a985422) 14.75%.
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5229      +/-   ##
==========================================
- Coverage   14.79%   14.75%   -0.05%     
==========================================
  Files        1648     1648              
  Lines      113928   114521     +593     
  Branches    35072    35557     +485     
==========================================
+ Hits        16860    16897      +37     
- Misses      78145    78664     +519     
- Partials    18923    18960      +37     
Flag Coverage Δ *Carryforward flag
differential 6.40% <0.00%> (?)
total 14.79% <ø> (+<0.01%) ⬆️ Carriedforward from 80cb8bf

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...ity_intersection_module/src/scene_intersection.hpp 0.00% <ø> (ø)
...ity_intersection_module/src/scene_intersection.cpp 0.00% <0.00%> (ø)
...avior_velocity_intersection_module/src/manager.cpp 24.59% <0.00%> (+7.99%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soblin
Copy link
Contributor

soblin commented Oct 5, 2023

Can you also remove the stuck_private_timeout_ variable because it is not used anymore?

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
@yuki-takagi-66
Copy link
Contributor Author

@soblin Thank you for the comments.
I've delete unused variables.

@yuki-takagi-66 yuki-takagi-66 merged commit 950805f into autowarefoundation:main Oct 6, 2023
22 of 25 checks passed
@yuki-takagi-66 yuki-takagi-66 deleted the feat/takagi-intersection-make-configulable branch October 6, 2023 04:54
yuki-takagi-66 added a commit to tier4/autoware.universe that referenced this pull request Oct 6, 2023
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
takayuki5168 pushed a commit to tier4/autoware.universe that referenced this pull request Oct 8, 2023
…eas (autowarefoundation#5229)

* feat: make configurable to disable the exception treat of stuck obstacle in the private areas
feat: change behavior in the private areas

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>

* delete the coment outed lines

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>

* change "enabled" to "enable"

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>

* fix setting

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>

* delete unused variables

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>

---------

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
takayuki5168 pushed a commit to tier4/autoware.universe that referenced this pull request Oct 11, 2023
…eas (autowarefoundation#5229)

* feat: make configurable to disable the exception treat of stuck obstacle in the private areas
feat: change behavior in the private areas

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>

* delete the coment outed lines

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>

* change "enabled" to "enable"

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>

* fix setting

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>

* delete unused variables

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>

---------

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants