Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(mpc): add default value #3976

Merged
merged 2 commits into from
Jun 15, 2023

Conversation

TakaHoribe
Copy link
Contributor

@TakaHoribe TakaHoribe commented Jun 14, 2023

Description

Add default parameter value to fix the test in mpc

Tests performed

pass test on CI

Effects on system behavior

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
@TakaHoribe TakaHoribe requested review from takayuki5168 and a team as code owners June 14, 2023 09:27
@github-actions github-actions bot added the component:control Vehicle control algorithms and mechanisms. (auto-assigned) label Jun 14, 2023
@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.99 ⚠️

Comparison is base (7a0e1c0) 15.40% compared to head (13da41f) 14.41%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3976      +/-   ##
==========================================
- Coverage   15.40%   14.41%   -0.99%     
==========================================
  Files        1350     1456     +106     
  Lines       96065   102643    +6578     
  Branches    29732    29722      -10     
==========================================
- Hits        14796    14794       -2     
- Misses      65108    71689    +6581     
+ Partials    16161    16160       -1     
Flag Coverage Δ *Carryforward flag
differential 46.95% <ø> (?)
total 14.41% <ø> (-0.99%) ⬇️ Carriedforward from e1be8cc

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
..._controller/include/mpc_lateral_controller/mpc.hpp 63.15% <ø> (ø)

... and 113 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@TomohitoAndo TomohitoAndo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TakaHoribe TakaHoribe merged commit f083fd2 into autowarefoundation:main Jun 15, 2023
@TakaHoribe TakaHoribe deleted the mpc-add-default-value branch June 15, 2023 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants