Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(start_planner): fix start planner pendulum #3972

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Jun 14, 2023

Description

Fix #3951.

In this PR, do not run start_planner if the ego vehicle is close to the goal.

Related links

#3951

tier4 internal slack

Tests performed

psim

fix_pendulum_planner-2023-06-14_13.48.36.mp4

Notes for reviewers

Interface changes

none

Effects on system behavior

none

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jun 14, 2023
@kyoichi-sugahara kyoichi-sugahara self-assigned this Jun 14, 2023
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Patch coverage: 40.00% and no project coverage change.

Comparison is base (57c958f) 14.41% compared to head (5449f8e) 14.41%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3972   +/-   ##
=======================================
  Coverage   14.41%   14.41%           
=======================================
  Files        1456     1456           
  Lines      102660   102660           
  Branches    29728    29729    +1     
=======================================
+ Hits        14795    14797    +2     
+ Misses      71705    71702    -3     
- Partials    16160    16161    +1     
Flag Coverage Δ *Carryforward flag
differential 12.86% <40.00%> (?)
total 14.41% <ø> (+<0.01%) ⬆️ Carriedforward from 57c958f

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
..._localizer/include/ekf_localizer/ekf_localizer.hpp 0.00% <ø> (ø)
localization/ekf_localizer/src/ekf_localizer.cpp 0.00% <ø> (ø)
...cene_module/start_planner/start_planner_module.cpp 6.13% <40.00%> (+0.43%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kosuke55 kosuke55 merged commit b8ddaf5 into main Jun 14, 2023
@kosuke55 kosuke55 deleted the fix/start_planner_pendulum branch June 14, 2023 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vehicle does not stop by goal pose in planning simulator
2 participants