Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(vehicle_cmd_gate): rename adapi pause interface #3794

Conversation

isamu-takagi
Copy link
Contributor

@isamu-takagi isamu-takagi commented May 23, 2023

Description

Since the pause interface has specialized processing for AD API and its name is confusing, I changed its name and added a comment.

Tests performed

Check autonomous mode driving in simple planning simulator.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@isamu-takagi isamu-takagi requested review from TakaHoribe, tkimura4 and a team as code owners May 23, 2023 03:55
@github-actions github-actions bot added the component:control Vehicle control algorithms and mechanisms. (auto-assigned) label May 23, 2023
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@isamu-takagi isamu-takagi self-assigned this May 23, 2023
@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Patch coverage: 14.28% and project coverage change: -0.42 ⚠️

Comparison is base (68f6f2f) 14.44% compared to head (e53c506) 14.03%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3794      +/-   ##
==========================================
- Coverage   14.44%   14.03%   -0.42%     
==========================================
  Files        1456     1440      -16     
  Lines      102483    99791    -2692     
  Branches    29691    26333    -3358     
==========================================
- Hits        14806    14006     -800     
+ Misses      71523    70455    -1068     
+ Partials    16154    15330     -824     
Flag Coverage Δ *Carryforward flag
differential 19.40% <0.00%> (?)
total 14.04% <100.00%> (-0.41%) ⬇️ Carriedforward from fd71b6d

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...rol/vehicle_cmd_gate/src/adapi_pause_interface.cpp 0.00% <0.00%> (ø)
control/vehicle_cmd_gate/src/vehicle_cmd_gate.cpp 0.29% <0.00%> (ø)
control/vehicle_cmd_gate/src/vehicle_cmd_gate.hpp 0.00% <ø> (ø)
...anner/include/behavior_path_planner/parameters.hpp 50.00% <ø> (ø)
...lanner/scene_module/avoidance/avoidance_module.hpp 0.00% <ø> (ø)
..._planner/utils/avoidance/avoidance_module_data.hpp 0.00% <ø> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp 19.09% <ø> (+0.44%) ⬆️
...er/src/scene_module/avoidance/avoidance_module.cpp 4.18% <ø> (+0.34%) ⬆️
planning/rtc_interface/src/rtc_interface.cpp 14.28% <100.00%> (-18.05%) ⬇️

... and 172 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@isamu-takagi
Copy link
Contributor Author

@TakaHoribe @tkimura4 I have resolved the conflict.

Copy link
Contributor

@TakaHoribe TakaHoribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isamu-takagi isamu-takagi enabled auto-merge (squash) June 8, 2023 04:06
@isamu-takagi isamu-takagi merged commit 69e89d9 into autowarefoundation:main Jun 8, 2023
@isamu-takagi isamu-takagi deleted the refactor/rename-adapi-pause-interface branch November 22, 2023 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants