-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(behavior_path_planner): support dynamic reconfigure on new manager #3581
feat(behavior_path_planner): support dynamic reconfigure on new manager #3581
Conversation
planning/behavior_path_planner/src/scene_module/avoidance/manager.cpp
Outdated
Show resolved
Hide resolved
planning/behavior_path_planner/src/scene_module/avoidance/manager.cpp
Outdated
Show resolved
Hide resolved
planning/behavior_path_planner/src/scene_module/avoidance/manager.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #3581 +/- ##
=======================================
Coverage 14.08% 14.08%
=======================================
Files 1396 1396
Lines 98021 98019 -2
Branches 29077 29075 -2
=======================================
Hits 13809 13809
Misses 69549 69549
+ Partials 14663 14661 -2
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
099a5d1
to
f439f71
Compare
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
f439f71
to
2413dcb
Compare
…er (autowarefoundation#3581) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…er (autowarefoundation#3581) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…er (autowarefoundation#3581) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…er (autowarefoundation#3581) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…er (autowarefoundation#3581) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…er (autowarefoundation#3581) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>
Description
the planner manager supports dynamic reconfigure. (+ add some params in updateModuleParams in avoidance manager.)
simplescreenrecorder-2023-04-28_23.42.15.mp4
Tests performed
Psim
Effects on system behavior
Nothing.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.