Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_path_planner): support dynamic reconfigure on new manager #3581

Merged

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Apr 28, 2023

Description

the planner manager supports dynamic reconfigure. (+ add some params in updateModuleParams in avoidance manager.)

simplescreenrecorder-2023-04-28_23.42.15.mp4

Tests performed

Psim

Effects on system behavior

Nothing.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Apr 28, 2023
@satoshi-ota satoshi-ota marked this pull request as ready for review April 28, 2023 14:44
Copy link
Contributor

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (279b64a) 14.08% compared to head (2413dcb) 14.08%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3581   +/-   ##
=======================================
  Coverage   14.08%   14.08%           
=======================================
  Files        1396     1396           
  Lines       98021    98019    -2     
  Branches    29077    29075    -2     
=======================================
  Hits        13809    13809           
  Misses      69549    69549           
+ Partials    14663    14661    -2     
Flag Coverage Δ *Carryforward flag
differential 15.41% <ø> (?)
total 14.08% <ø> (+<0.01%) ⬆️ Carriedforward from 279b64a

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...or_path_planner/src/behavior_path_planner_node.cpp 20.00% <ø> (+0.05%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota satoshi-ota merged commit 3766d5a into autowarefoundation:main Apr 30, 2023
@satoshi-ota satoshi-ota deleted the feat/dynamic-reconf branch April 30, 2023 08:00
satoshi-ota added a commit to satoshi-ota/autoware.universe that referenced this pull request May 5, 2023
…er (autowarefoundation#3581)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota added a commit to satoshi-ota/autoware.universe that referenced this pull request May 5, 2023
…er (autowarefoundation#3581)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota added a commit to satoshi-ota/autoware.universe that referenced this pull request May 5, 2023
…er (autowarefoundation#3581)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request May 6, 2023
…er (autowarefoundation#3581)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota added a commit to satoshi-ota/autoware.universe that referenced this pull request Jun 20, 2023
…er (autowarefoundation#3581)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Mingyu1991 pushed a commit to Mingyu1991/autoware.universe that referenced this pull request Jun 26, 2023
…er (autowarefoundation#3581)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants