Skip to content

Commit

Permalink
chore(autoware_pcl_extensions): refactored the pcl_extensions (#8220)
Browse files Browse the repository at this point in the history
chore: refactored the pcl_extensions according to the new rules

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
  • Loading branch information
knzo25 committed Aug 20, 2024
1 parent d4a0443 commit 8abf07b
Show file tree
Hide file tree
Showing 10 changed files with 19 additions and 19 deletions.
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,7 @@ planning/sampling_based_planner/autoware_path_sampler/** maxime.clement@tier4.jp
planning/sampling_based_planner/autoware_sampler_common/** maxime.clement@tier4.jp
sensing/autoware_image_diagnostics/** dai.nguyen@tier4.jp yoshi.ri@tier4.jp
sensing/autoware_image_transport_decompressor/** kenzo.lobos@tier4.jp yukihiro.saito@tier4.jp
sensing/autoware_pcl_extensions/** david.wong@tier4.jp kenzo.lobos@tier4.jp ryu.yamamoto@tier4.jp
sensing/autoware_pointcloud_preprocessor/** abrahammonrroy@yahoo.com dai.nguyen@tier4.jp david.wong@tier4.jp kenzo.lobos@tier4.jp kyoichi.sugahara@tier4.jp melike@leodrive.ai shunsuke.miura@tier4.jp yihsiang.fang@tier4.jp yoshi.ri@tier4.jp yukihiro.saito@tier4.jp
sensing/autoware_radar_scan_to_pointcloud2/** satoshi.tanaka@tier4.jp shunsuke.miura@tier4.jp taekjin.lee@tier4.jp yoshi.ri@tier4.jp
sensing/autoware_radar_static_pointcloud_filter/** satoshi.tanaka@tier4.jp shunsuke.miura@tier4.jp taekjin.lee@tier4.jp yoshi.ri@tier4.jp
Expand All @@ -209,7 +210,6 @@ sensing/autoware_radar_tracks_noise_filter/** satoshi.tanaka@tier4.jp shunsuke.m
sensing/gnss_poser/** anh.nguyen.2@tier4.jp kento.yabuuchi.2@tier4.jp masahiro.sakamoto@tier4.jp ryu.yamamoto@tier4.jp shintaro.sakoda@tier4.jp taiki.yamada@tier4.jp yamato.ando@tier4.jp
sensing/imu_corrector/** taiki.yamada@tier4.jp yamato.ando@tier4.jp
sensing/livox/autoware_livox_tag_filter/** kenzo.lobos@tier4.jp ryohsuke.mitsudome@tier4.jp
sensing/tier4_pcl_extensions/** david.wong@tier4.jp kenzo.lobos@tier4.jp ryu.yamamoto@tier4.jp
sensing/vehicle_velocity_converter/** ryu.yamamoto@tier4.jp
simulator/autoware_carla_interface/** maxime.clement@tier4.jp mradityagio@gmail.com
simulator/dummy_perception_publisher/** yukihiro.saito@tier4.jp
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
cmake_minimum_required(VERSION 3.14)
project(tier4_pcl_extensions)
project(autoware_pcl_extensions)

find_package(autoware_cmake REQUIRED)
autoware_package()
Expand All @@ -16,10 +16,10 @@ include_directories(
link_directories(${PCL_LIBRARY_DIRS})
add_definitions(${PCL_DEFINITIONS})

ament_auto_add_library(tier4_pcl_extensions SHARED
ament_auto_add_library(autoware_pcl_extensions SHARED
src/voxel_grid_nearest_centroid.cpp
)

target_link_libraries(tier4_pcl_extensions ${PCL_LIBRARIES})
target_link_libraries(autoware_pcl_extensions ${PCL_LIBRARIES})

ament_auto_package()
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
# tier4_pcl_extensions
# autoware_pcl_extensions

## Purpose

The `tier4_pcl_extensions` is a pcl extension library. The voxel grid filter in this package works with a different algorithm than the original one.
The `autoware_pcl_extensions` is a pcl extension library. The voxel grid filter in this package works with a different algorithm than the original one.

## Inner-workings / Algorithms

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@
*
*/

#ifndef TIER4_PCL_EXTENSIONS__VOXEL_GRID_NEAREST_CENTROID_HPP_
#define TIER4_PCL_EXTENSIONS__VOXEL_GRID_NEAREST_CENTROID_HPP_
#ifndef AUTOWARE__PCL_EXTENSIONS__VOXEL_GRID_NEAREST_CENTROID_HPP_
#define AUTOWARE__PCL_EXTENSIONS__VOXEL_GRID_NEAREST_CENTROID_HPP_

#include <pcl/pcl_config.h>

Expand Down Expand Up @@ -541,4 +541,4 @@ class VoxelGridNearestCentroid : public VoxelGrid<PointT>
#include <voxel_grid_approxi.hpp>
#endif

#endif // TIER4_PCL_EXTENSIONS__VOXEL_GRID_NEAREST_CENTROID_HPP_
#endif // AUTOWARE__PCL_EXTENSIONS__VOXEL_GRID_NEAREST_CENTROID_HPP_
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,10 @@
*
*/

#ifndef TIER4_PCL_EXTENSIONS__VOXEL_GRID_NEAREST_CENTROID_IMPL_HPP_
#define TIER4_PCL_EXTENSIONS__VOXEL_GRID_NEAREST_CENTROID_IMPL_HPP_
#ifndef AUTOWARE__PCL_EXTENSIONS__VOXEL_GRID_NEAREST_CENTROID_IMPL_HPP_
#define AUTOWARE__PCL_EXTENSIONS__VOXEL_GRID_NEAREST_CENTROID_IMPL_HPP_

#include "tier4_pcl_extensions/voxel_grid_nearest_centroid.hpp"
#include "autoware/pcl_extensions/voxel_grid_nearest_centroid.hpp"

#include <Eigen/Cholesky>
#include <Eigen/Dense>
Expand Down Expand Up @@ -347,4 +347,4 @@ void pcl::VoxelGridNearestCentroid<PointT>::applyFilter(PointCloud & output)
#define PCL_INSTANTIATE_VoxelGridNearestCentroid(T) \
template class PCL_EXPORTS pcl::VoxelGridNearestCentroid<T>;

#endif // TIER4_PCL_EXTENSIONS__VOXEL_GRID_NEAREST_CENTROID_IMPL_HPP_
#endif // AUTOWARE__PCL_EXTENSIONS__VOXEL_GRID_NEAREST_CENTROID_IMPL_HPP_
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<?xml version="1.0"?>
<?xml-model href="http://download.ros.org/schema/package_format3.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
<package format="3">
<name>tier4_pcl_extensions</name>
<name>autoware_pcl_extensions</name>
<version>0.1.0</version>
<description>The tier4_pcl_extensions package</description>
<description>The autoware_pcl_extensions package</description>
<maintainer email="ryu.yamamoto@tier4.jp">Ryu Yamamoto</maintainer>
<maintainer email="kenzo.lobos@tier4.jp">Kenzo Lobos Tsunekawa</maintainer>
<maintainer email="david.wong@tier4.jp">David Wong</maintainer>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
*
*/

#include "tier4_pcl_extensions/voxel_grid_nearest_centroid_impl.hpp"
#include "autoware/pcl_extensions/voxel_grid_nearest_centroid_impl.hpp"

#include <pcl/filters/impl/voxel_grid.hpp>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ The `downsample_filter` is a node that reduces the number of points.

### Approximate Downsample Filter

`pcl::VoxelGridNearestCentroid` is used. The algorithm is described in [tier4_pcl_extensions](../../tier4_pcl_extensions/README.md)
`pcl::VoxelGridNearestCentroid` is used. The algorithm is described in [autoware_pcl_extensions](../../autoware_pcl_extensions/README.md)

### Random Downsample Filter

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@

#include "autoware/pointcloud_preprocessor/filter.hpp"

#include <tier4_pcl_extensions/voxel_grid_nearest_centroid.hpp>
#include <autoware/pcl_extensions/voxel_grid_nearest_centroid.hpp>

#include <pcl/filters/voxel_grid.h>
#include <pcl/search/pcl_search.h>
Expand Down
2 changes: 1 addition & 1 deletion sensing/autoware_pointcloud_preprocessor/package.xml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
<buildtool_depend>autoware_cmake</buildtool_depend>

<depend>autoware_lanelet2_extension</depend>
<depend>autoware_pcl_extensions</depend>
<depend>autoware_point_types</depend>
<depend>autoware_universe_utils</depend>
<depend>cgal</depend>
Expand All @@ -49,7 +50,6 @@
<depend>tf2_geometry_msgs</depend>
<depend>tf2_ros</depend>
<depend>tier4_debug_msgs</depend>
<depend>tier4_pcl_extensions</depend>

<test_depend>ament_lint_auto</test_depend>
<test_depend>autoware_lint_common</test_depend>
Expand Down

0 comments on commit 8abf07b

Please sign in to comment.