-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate AsdfExtension, AsdfExtensionList, BuiltinExtension #1429
Deprecate AsdfExtension, AsdfExtensionList, BuiltinExtension #1429
Conversation
0e38f0a
to
bb47d76
Compare
|
6ec8e60
to
96c6902
Compare
96c6902
to
fc3b5a5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
def __getattr__(name): | ||
if name == "AsdfExtension": | ||
# defer import to only issue deprecation warning when | ||
# asdf.AsdfExtension is used | ||
from asdf import extension | ||
|
||
return extension.AsdfExtension | ||
msg = f"module {__name__!r} has no attribute {name!r}" | ||
raise AttributeError(msg) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is nice.
How did this not show up in #1433? From the astropy downstream
|
astropy downstream will be fixed by astropy/astropy#14436 |
…ist, BuiltinExtension
Currently based off of #1409 and should not be merged before that PR.