-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecate asdf_extensions entry point #1361
Merged
WilliamJamieson
merged 4 commits into
asdf-format:master
from
braingram:deprecate/asdf_extensions_entry_point
Feb 23, 2023
Merged
deprecate asdf_extensions entry point #1361
WilliamJamieson
merged 4 commits into
asdf-format:master
from
braingram:deprecate/asdf_extensions_entry_point
Feb 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braingram
force-pushed
the
deprecate/asdf_extensions_entry_point
branch
from
February 13, 2023 16:25
df276e6
to
1a7c47b
Compare
15 tasks
braingram
force-pushed
the
deprecate/asdf_extensions_entry_point
branch
2 times, most recently
from
February 22, 2023 19:07
1e9e2ad
to
d25bfde
Compare
|
braingram
force-pushed
the
deprecate/asdf_extensions_entry_point
branch
from
February 22, 2023 19:52
d25bfde
to
31a4d25
Compare
WilliamJamieson
suggested changes
Feb 22, 2023
braingram
force-pushed
the
deprecate/asdf_extensions_entry_point
branch
from
February 22, 2023 22:00
31a4d25
to
4aded1b
Compare
@WilliamJamieson Thanks for catching those. They were all stale changes that are no longer required due to the work done to revive this PR. |
WilliamJamieson
suggested changes
Feb 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please rebase to pickup up the .tox
changes.
braingram
force-pushed
the
deprecate/asdf_extensions_entry_point
branch
from
February 23, 2023 15:50
4aded1b
to
8cfe255
Compare
WilliamJamieson
approved these changes
Feb 23, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/asdf
that referenced
this pull request
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
asdf_extensions
entry point is only used by the legacy, deprecated extension api.This PR adds a deprecation warning triggered when this entry point is used.
Fixes #1333