-
Notifications
You must be signed in to change notification settings - Fork 78
[Toolchain] Update Typescript to 3.0.3 #1185
Changes from all commits
587262f
dcb2f7d
312ff8b
a7eb655
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
src/__generated__/*.ts | ||
src/__generated__/*.json | ||
src/__generated__/*.graphql.ts | ||
node_modules |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
patch-package | ||
--- a/node_modules/@types/react-native/index.d.ts | ||
+++ b/node_modules/@types/react-native/index.d.ts | ||
@@ -8435,8 +8435,9 @@ export type Clipboard = ClipboardStatic; | ||
export var DatePickerAndroid: DatePickerAndroidStatic; | ||
export type DatePickerAndroid = DatePickerAndroidStatic; | ||
|
||
-export var Geolocation: GeolocationStatic; | ||
-export type Geolocation = GeolocationStatic; | ||
+// https://github.com/DefinitelyTyped/DefinitelyTyped/issues/24573 | ||
+// export var Geolocation: GeolocationStatic; | ||
+// export type Geolocation = GeolocationStatic; | ||
|
||
/** http://facebook.github.io/react-native/blog/2016/08/19/right-to-left-support-for-react-native-apps.html */ | ||
export var I18nManager: I18nManagerStatic; |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gah, didn’t know we had this issue. This should really be worked around by getting rid of
@types/node
, because RN is not Node.Looks like it’s being pulled in by enzyme/cheerio?? No clue why that would be a good idea of them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enzyme discusses this a bit here: https://github.com/airbnb/enzyme/blob/master/docs/api/render.md#static-rendering-api
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually meant that no package should list
@types/*
packages as runtime deps. In this case it wasparse5
(didn’t read properly yesterday). You can see that in v5.1.0 they removed this inikulin/parse5@4350f6a#diff-b9cfc7f2cdf78a7f4b91a753d10865a2, so the fix would be for us to force resolution of that version instead of the one that cheerio depends on.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting:
I removed the patch, and updated the resolution, yet the error re-appears.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you do
yarn why @types/node
instead?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.