[Toolchain] Update Typescript to 3.0.3 #1185
Conversation
| @@ -5,6 +5,7 @@ | |||
| "baseUrl": "src", | |||
| "experimentalDecorators": true, | |||
| "jsx": "react", | |||
| "keyofStringsOnly": true, | |||
There was a problem hiding this comment.
mzikherman
force-pushed
the
chris-upgrade-typescript
branch
from
9048c08
to
587262f
Compare
|
|
||
| -export var Geolocation: GeolocationStatic; | ||
| -export type Geolocation = GeolocationStatic; | ||
| +// https://github.com/DefinitelyTyped/DefinitelyTyped/issues/24573 |
There was a problem hiding this comment.
Gah, didn’t know we had this issue. This should really be worked around by getting rid of @types/node, because RN is not Node.
Looks like it’s being pulled in by enzyme/cheerio?? No clue why that would be a good idea of them.
=> Found "@types/node@8.5.1"
info Reasons this module exists
- "enzyme#cheerio#parse5" depends on it
- Hoisted from "enzyme#cheerio#parse5#@types#node"
There was a problem hiding this comment.
Enzyme discusses this a bit here: https://github.com/airbnb/enzyme/blob/master/docs/api/render.md#static-rendering-api
There was a problem hiding this comment.
I actually meant that no package should list @types/* packages as runtime deps. In this case it was parse5 (didn’t read properly yesterday). You can see that in v5.1.0 they removed this inikulin/parse5@4350f6a#diff-b9cfc7f2cdf78a7f4b91a753d10865a2, so the fix would be for us to force resolution of that version instead of the one that cheerio depends on.
There was a problem hiding this comment.
Interesting:
I removed the patch, and updated the resolution, yet the error re-appears.
There was a problem hiding this comment.
Can you do yarn why @types/node instead?
|
@alloy - Oh weird, I wonder what happened there re relay fragments; my first push only sent up a couple files. I think this might have just happened on rebase -- investigating. |
|
Yup, this looks like a Prettier thing which I presume was triggered after Typescript re-ran post update. |
| "member-access": [false, "check-accessor", "check-constructor"], | ||
| "no-console": [true, ["error", ["warn", "error"]]], | ||
| "no-unused-variable": [true, { "ignore-pattern": "^_" }], |
There was a problem hiding this comment.
|
Part of me wonders if we should add |
|
@orta - I would agree with this; I don't think we should transform generated files. |
mzikherman
force-pushed
the
chris-upgrade-typescript
branch
from
7082145
to
312ff8b
Compare
|
This LGTM. It would be great if you could address that |
|
@damassi Sigh. Well, commit that anyways, there’s absolutely no need for |
|
Ok mergin' |
Upgrades Typescript and TSLint to latest, and followed a few work-arounds to get it green since we're a few versions behind in terms of
react-native/react.