fix(ui): carry over state when using full screen mode button

[linghaoSu]

Fixes #20012

Now

2024-09-20.10.05.05.480.mov

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• The title of the PR conforms to the Toolchain Guide
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).
• My new feature complies with the feature status guidelines.
• I have added a brief description of why this PR is necessary and/or what this PR solves.
• Optional. My organization is added to USERS.md.
• Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

[bunnyshell]

✅ Preview Environment deployed on Bunnyshell

Component	Endpoints
argocd	https://argocd-agfxop.bunnyenv.com/
argocd-ttyd	https://argocd-web-cli-agfxop.bunnyenv.com/

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

• 🔴 /bns:stop to stop the environment
• 🚀 /bns:deploy to redeploy the environment
• ❌ /bns:delete to remove the environment

[bunnyshell]

✅ Preview Environment created on Bunnyshell but will not be auto-deployed

See: Environment Details

Available commands (reply to this comment):

• 🚀 /bns:deploy to deploy the environment

[nitishfy]

LGTM! Thanks

[jsoref]

• Wrap long lines carried over 😄
• Wrap show pod names carried over 😄
• Show timestamps didn't carry over 😦

You're going to want to change the description to:

fix(ui): carry over state when using full screen mode button or something like that.

[linghaoSu]

@jsoref Thanks for the review

• Show timestamps didn't carry over

argo-cd/ui/src/app/applications/components/pod-logs-viewer/pod-logs-viewer.tsx

Lines 89 to 93 in 6b6d23b

	useEffect(() => {
	if (viewPodNames) {
	setViewTimestamps(false);
	}
	}, [viewPodNames]);

This is because the original logic here was that if viewPodNames was turned on, the side effect here would turn viewTimestamps off, and this caused the side effect to be executed immediately when viewTimestamps was turned on, turning viewTimestamps off.

So instead, we use events to keep the original logic of closing viewStamps when podNames are opened.

fix(ui): carry over state when using full screen mode button or something like that.

The pr title you suggested was great, so I went ahead and used it!

[alexmt]

Awesome. I also wanted this behavior