Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show pod names state should be applied when logs popped out #20012

Open
3 tasks done
jsoref opened this issue Sep 19, 2024 · 3 comments · May be fixed by #20022
Open
3 tasks done

Show pod names state should be applied when logs popped out #20012

jsoref opened this issue Sep 19, 2024 · 3 comments · May be fixed by #20022
Labels
bug Something isn't working component:logging component:ui User interfaces bugs and enhancements ui-polish

Comments

@jsoref
Copy link
Member

jsoref commented Sep 19, 2024

Checklist:

  • I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
  • I've included steps to reproduce the bug.
  • I've pasted the output of argocd version.

Describe the bug

Log options aren't applied to newly popped out full screen logs view.

To Reproduce

  1. Visit https://cd.apps.argoproj.io/applications/argo-cd?resource=kind%3APod&podSortMode=topLevelResource&node=apps%2FStatefulSet%2Fargocd%2Fargocd-redis-ha-server%2F0&tab=logs
  2. Activate Show pod names image
    image
  3. Activate Show logs in fullscreen in a new window image

Expected behavior

Show pod names should be active in the logs full screen in the new window

Screenshots

https://cd.apps.argoproj.io/applications/argocd/argo-cd/argocd/redis/logs?podName=&group=apps&kind=StatefulSet&name=argocd-redis-ha-server
image

Version

{
    "Version": "v2.11.0+1cffa15",
    "BuildDate": "2024-04-18T08:51:13Z",
    "GitCommit": "1cffa15f0ddecbc241d572e316ea20920fdfdb65",
    "GitTreeState": "clean",
    "GoVersion": "go1.21.9",
    "Compiler": "gc",
    "Platform": "linux/amd64",
    "KustomizeVersion": "v5.2.1 2023-10-19T20:13:51Z",
    "HelmVersion": "v3.14.3+gf03cc04",
    "KubectlVersion": "v0.26.11",
    "JsonnetVersion": "v0.20.0"
}

Logs

@jsoref jsoref added bug Something isn't working ui-polish labels Sep 19, 2024
@linghaoSu linghaoSu linked a pull request Sep 20, 2024 that will close this issue
14 tasks
@linghaoSu
Copy link
Contributor

Hi, I fixed the issue of opening the log page in full screen without the viewPodName, but I'm also seeing a lot of other settings

  1. such as viewTimestamp, do I need to fix that?
  2. and viewPodNames is currently taken from the query of the url, while wrap is taken from the preference, is it necessary to be consistent 🤔.

@jsoref
Copy link
Member Author

jsoref commented Sep 20, 2024

I'd certainly prefer for all of them to be applied.

@todaywasawesome todaywasawesome added component:logging component:ui User interfaces bugs and enhancements labels Sep 20, 2024
@linghaoSu
Copy link
Contributor

Hi, I've taken all the configurations from the url query parameter of the log view and synced them to the query of the url when it's updated.

  1. when using the fullscreen button, take these configurations with you
  2. share the url with the same configuration as the current url.

Now that the pr is ready to be reviewed, could you please review it to see if it meets expectations?
#20022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component:logging component:ui User interfaces bugs and enhancements ui-polish
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants