Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adding namespace to badges url with "Applications in any namespace" (#15655) #15771

Closed
wants to merge 1 commit into from
Closed

fix: adding namespace to badges url with "Applications in any namespace" (#15655) #15771

wants to merge 1 commit into from

Conversation

nandinisingh759
Copy link
Contributor

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

Closes #15655

@nandinisingh759 nandinisingh759 requested a review from a team as a code owner October 2, 2023 18:45
adding namespace to badges url
008c82b 
Signed-off-by: Nandini Singh <nandini_singh@intuit.com>
@asapekia
Copy link

asapekia commented Oct 2, 2023

PR already available for this issue. #15749

jannfis
jannfis reviewed Oct 2, 2023
View reviewed changes
ui/src/app/shared/components/badge-panel/badge-panel.tsx
Comment on lines +23 to +25
if (nsEnabled) {
badgeURL += `&namespace=${appNamespace}`
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this check is not necessary; you can pass the namespace parameter regardless of whether apps-in-any-namespace is enabled. However, passing a namespace other than the installation namespace to an Argo CD that does not have apps-in-any-namespace enabled, will result in an error.

@sonamkshenoy
Copy link
Member

sonamkshenoy commented Jan 29, 2024 •
edited
Loading

The UI isn't working/loading with the changes in the PR.
Has been fixed by #16739

@sonamkshenoy sonamkshenoy mentioned this pull request Jan 29, 2024
Closed
5 tasks
@ishitasequeira
Copy link
Member

closing this as the changes are already fixed in PR #16739

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jannfis jannfis jannfis left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI: badges url not containing namespace with "Applications in any namespace"
5 participants
@nandinisingh759 @asapekia @sonamkshenoy @ishitasequeira @jannfis