Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): add namespace in badge url for apps-in-any-namespace (#15655) #15749

Closed
wants to merge 7 commits into from
Closed

fix(ui): add namespace in badge url for apps-in-any-namespace (#15655) #15749

wants to merge 7 commits into from

Conversation

asapekia
Copy link

@asapekia asapekia commented Sep 30, 2023 •
edited
Loading

closes #15655
Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

@asapekia asapekia requested a review from a team as a code owner September 30, 2023 19:51
@asapekia asapekia changed the title fixes #15655 UI: badges url not containing namespace with "Applications in any namespace fix: #15655 UI: badges url not containing namespace with "Applications in any namespace Sep 30, 2023
@asapekia asapekia changed the title fix: #15655 UI: badges url not containing namespace with "Applications in any namespace fix: This PR closes #15655 badges url not containing namespace with "Applications in any namespace" Sep 30, 2023
@codecov
Copy link

codecov bot commented Sep 30, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (af17c8d) 49.66% compared to head (ceb8cd9) 49.67%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #15749   +/-   ##
=======================================
  Coverage   49.66%   49.67%           
=======================================
  Files         267      267           
  Lines       46383    46383           
=======================================
+ Hits        23036    23039    +3     
+ Misses      21086    21084    -2     
+ Partials     2261     2260    -1

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

asapekia and others added 2 commits October 1, 2023 01:48
@asapekia
fixes argoproj#15655
e76168d 
Signed-off-by: Arin <136636751+asapekia@users.noreply.github.com>
@PranitRout07 @asapekia
Fixed Custom Link Text not Hyperlinked (argoproj#15747)
6bd369c 
Visit this link to see the issue : https://argo-cd.readthedocs.io/en/stable/developer-guide/ci/#public-cd

Signed-off-by: PranitRout07 <102309095+PranitRout07@users.noreply.github.com>
Signed-off-by: Arin <136636751+asapekia@users.noreply.github.com>
@asapekia asapekia requested a review from a team as a code owner September 30, 2023 20:18
@asapekia
Copy link
Author

asapekia commented Oct 1, 2023

@crenshaw-dev please review.

@asapekia asapekia mentioned this pull request Oct 2, 2023
Closed
13 tasks
@asapekia
Copy link
Author

asapekia commented Oct 3, 2023

Please let me know if any change is required.

@crenshaw-dev crenshaw-dev changed the title fix: This PR closes #15655 badges url not containing namespace with "Applications in any namespace" fix(ui): add namespace in badge url for apps-in-any-namespace (#15655) Oct 3, 2023
@asapekia
Copy link
Author

asapekia commented Oct 7, 2023

the integration tests passed just by updating the branch. Don't understand why.

@asapekia
Copy link
Author

asapekia commented Nov 6, 2023

@jannfis Please review this PR.

@crenshaw-dev crenshaw-dev added the component:ui User interfaces bugs and enhancements label Nov 14, 2023
ashutosh16
ashutosh16 approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@ashutosh16 ashutosh16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonamkshenoy
Copy link
Member

sonamkshenoy commented Jan 29, 2024 •
edited
Loading

UI isn't working/loading with the changes in the PR.
Has been fixed by #16739

@sonamkshenoy sonamkshenoy mentioned this pull request Jan 29, 2024
Closed
5 tasks
@ishitasequeira
Copy link
Member

closing this as the changes are already fixed in PR #16739

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashutosh16 ashutosh16 ashutosh16 approved these changes

Assignees
No one assigned
Labels
component:ui User interfaces bugs and enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI: badges url not containing namespace with "Applications in any namespace"
6 participants
@asapekia @sonamkshenoy @ishitasequeira @ashutosh16 @crenshaw-dev @PranitRout07