Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update documentation to reflect the procedure on current keycloak (#12495) #12505

Merged
merged 3 commits into from
Jun 27, 2023

Conversation

mmueller-rs
Copy link
Contributor

@mmueller-rs mmueller-rs commented Feb 17, 2023

Closes #12495

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (e8f5126) 49.76% compared to head (6ee9e68) 49.76%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #12505   +/-   ##
=======================================
  Coverage   49.76%   49.76%           
=======================================
  Files         261      261           
  Lines       44653    44653           
=======================================
  Hits        22222    22222           
  Misses      20248    20248           
  Partials     2183     2183           

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mmueller-rs mmueller-rs changed the title update documentation to reflect the procedure on current keycloak (#12495) docs: update documentation to reflect the procedure on current keycloak (#12495) Feb 17, 2023
Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Would you mind running the images through squoosh.app or similar? Trying to keep repo size down. :-)

versions

Signed-off-by: Max Mueller <mmueller@anynines.com>
@mmueller-rs
Copy link
Contributor Author

@crenshaw-dev I was able to reduce the image size to ~24-26% of the previous ones. Should be okay now.

@mmueller-rs
Copy link
Contributor Author

mmueller-rs commented Mar 24, 2023

@crenshaw-dev are there any more issues with this PR? Dhould I maybe sync it with master again?

Copy link
Contributor

@todaywasawesome todaywasawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now

@crenshaw-dev crenshaw-dev merged commit 5976d70 into argoproj:master Jun 27, 2023
@crenshaw-dev
Copy link
Member

@mmueller-a9s apologies for the delay, and thanks for the contribution! :-)

yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
…ak (argoproj#12505)

versions

Signed-off-by: Max Mueller <mmueller@anynines.com>
Co-authored-by: pasha-codefresh <pavel@codefresh.io>
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
…ak (argoproj#12505)

versions

Signed-off-by: Max Mueller <mmueller@anynines.com>
Co-authored-by: pasha-codefresh <pavel@codefresh.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs update: keycloak.md shows an old keycloak version and should be updated
4 participants