Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs update: keycloak.md shows an old keycloak version and should be updated #12495

Closed
mmueller-rs opened this issue Feb 16, 2023 · 3 comments · Fixed by #12505
Closed

docs update: keycloak.md shows an old keycloak version and should be updated #12495

mmueller-rs opened this issue Feb 16, 2023 · 3 comments · Fixed by #12505
Labels
enhancement New feature or request

Comments

@mmueller-rs
Copy link
Contributor

mmueller-rs commented Feb 16, 2023

Summary

The operator-manual to configure SSO with Keycloak seems to use a Keycloak version of ~13. By now, Keycloak version 20 is out and the UI has changed significantly.

Motivation

If one wants to configure ArgoCD to use Keycloak for SSO, one wants to use this documentation to configure the client.

Proposal

Go through the process and make new screenshots on how to configure the client properly.

Additional Info

There is already an updated version Draft in my fork: mmueller-a9s/argo-cd

@mmueller-rs mmueller-rs added the enhancement New feature or request label Feb 16, 2023
@mmueller-rs mmueller-rs changed the title docs update: keycloak.md uses an old keycloak version and should be updated docs update: keycloak.md shows an old keycloak version and should be updated Feb 16, 2023
@todaywasawesome
Copy link
Contributor

@mmueller-a9s Do you want to go ahead and add a pull request?

Functionally, are there any differences in the instructions or is it the same between versions?

@mmueller-rs
Copy link
Contributor Author

@todaywasawesome I've created a Pull Request: #12505
The functionality is the same between the versions. The only difference is that Keycloak removed the /auth from the path, but this has already been updated in e5e3b0f

I've configured a keycloak client in Keycloak v13 using the old documentation and updated Keycloak to v20. When I updated this documentation, I paid attention that the configuration is equal.
I also created a new keycloak client in Keycloak v20 using the new documentation and it worked.

@jbatmalle
Copy link

jbatmalle commented May 12, 2023

Hi @mmueller-a9s,
I tested with keycloack 21.1.1 (latest version) and they are the same screens as for version 20
It's works for me
Thanks to you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants