-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(appset): ArgoCD admin cmd: handle applicationsets RBAC #11997
Merged
crenshaw-dev
merged 2 commits into
argoproj:master
from
shuker85:fix/appset-cmd-rbac-admin
May 29, 2023
Merged
fix(appset): ArgoCD admin cmd: handle applicationsets RBAC #11997
crenshaw-dev
merged 2 commits into
argoproj:master
from
shuker85:fix/appset-cmd-rbac-admin
May 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuker85
force-pushed
the
fix/appset-cmd-rbac-admin
branch
from
January 16, 2023 15:12
fd9a400
to
b3dcdc0
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #11997 +/- ##
=======================================
Coverage 49.08% 49.09%
=======================================
Files 250 250
Lines 43248 43248
=======================================
+ Hits 21228 21231 +3
+ Misses 19890 19889 -1
+ Partials 2130 2128 -2
☔ View full report in Codecov by Sentry. |
shuker85
changed the title
ArgoCD admin cmd : handle applicationsets RBAC
fix: ArgoCD admin cmd: handle applicationsets RBAC
Jan 16, 2023
shuker85
force-pushed
the
fix/appset-cmd-rbac-admin
branch
from
January 16, 2023 21:57
9b3aa18
to
0d2670c
Compare
shuker85
force-pushed
the
fix/appset-cmd-rbac-admin
branch
4 times, most recently
from
January 19, 2023 19:41
fd44501
to
4499f0a
Compare
shuker85
force-pushed
the
fix/appset-cmd-rbac-admin
branch
from
January 28, 2023 08:16
4499f0a
to
cc072a5
Compare
shuker85
force-pushed
the
fix/appset-cmd-rbac-admin
branch
from
February 7, 2023 18:37
cc072a5
to
ffd61e2
Compare
shuker85
force-pushed
the
fix/appset-cmd-rbac-admin
branch
2 times, most recently
from
March 11, 2023 19:24
c461b0c
to
0ba182a
Compare
shuker85
force-pushed
the
fix/appset-cmd-rbac-admin
branch
from
March 13, 2023 09:46
0ba182a
to
bc5c768
Compare
Fixes [argoproj#11996] Adding more tests on logs/exec Signed-off-by: Shyukri Shyukriev <shyukri.shyukriev@mariadb.com>
shuker85
force-pushed
the
fix/appset-cmd-rbac-admin
branch
from
March 18, 2023 17:38
bc5c768
to
9325232
Compare
crenshaw-dev
changed the title
fix: ArgoCD admin cmd: handle applicationsets RBAC
fix(appset): ArgoCD admin cmd: handle applicationsets RBAC
May 29, 2023
crenshaw-dev
approved these changes
May 29, 2023
yyzxw
pushed a commit
to yyzxw/argo-cd
that referenced
this pull request
Aug 9, 2023
…#11997) Fixes [argoproj#11996] Adding more tests on logs/exec Signed-off-by: Shyukri Shyukriev <shyukri.shyukriev@mariadb.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
tesla59
pushed a commit
to tesla59/argo-cd
that referenced
this pull request
Dec 16, 2023
…#11997) Fixes [argoproj#11996] Adding more tests on logs/exec Signed-off-by: Shyukri Shyukriev <shyukri.shyukriev@mariadb.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes [#11996]
Adding more tests on logs/exec
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: