Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(appset): ArgoCD admin cmd: handle applicationsets RBAC #11997

Merged
merged 2 commits into from
May 29, 2023

Conversation

shuker85
Copy link
Contributor

@shuker85 shuker85 commented Jan 16, 2023

Fixes [#11996]

Adding more tests on logs/exec

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@shuker85 shuker85 marked this pull request as draft January 16, 2023 15:12
@codecov
Copy link

codecov bot commented Jan 16, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (7192eab) 49.08% compared to head (573449f) 49.09%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11997   +/-   ##
=======================================
  Coverage   49.08%   49.09%           
=======================================
  Files         250      250           
  Lines       43248    43248           
=======================================
+ Hits        21228    21231    +3     
+ Misses      19890    19889    -1     
+ Partials     2130     2128    -2     
Impacted Files Coverage Δ
cmd/argocd/commands/admin/settings_rbac.go 25.72% <ø> (+1.24%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@shuker85 shuker85 changed the title ArgoCD admin cmd : handle applicationsets RBAC fix: ArgoCD admin cmd: handle applicationsets RBAC Jan 16, 2023
@shuker85 shuker85 marked this pull request as ready for review January 16, 2023 22:10
@shuker85 shuker85 force-pushed the fix/appset-cmd-rbac-admin branch 4 times, most recently from fd44501 to 4499f0a Compare January 19, 2023 19:41
@shuker85 shuker85 force-pushed the fix/appset-cmd-rbac-admin branch 2 times, most recently from c461b0c to 0ba182a Compare March 11, 2023 19:24
@crenshaw-dev crenshaw-dev self-assigned this Mar 13, 2023
Fixes [argoproj#11996]

Adding more tests on logs/exec

Signed-off-by: Shyukri Shyukriev <shyukri.shyukriev@mariadb.com>
@crenshaw-dev crenshaw-dev changed the title fix: ArgoCD admin cmd: handle applicationsets RBAC fix(appset): ArgoCD admin cmd: handle applicationsets RBAC May 29, 2023
@crenshaw-dev crenshaw-dev enabled auto-merge (squash) May 29, 2023 16:47
@crenshaw-dev crenshaw-dev merged commit 4c982b2 into argoproj:master May 29, 2023
yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
…#11997)

Fixes [argoproj#11996]

Adding more tests on logs/exec

Signed-off-by: Shyukri Shyukriev <shyukri.shyukriev@mariadb.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
…#11997)

Fixes [argoproj#11996]

Adding more tests on logs/exec

Signed-off-by: Shyukri Shyukriev <shyukri.shyukriev@mariadb.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants