Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArgoCD cmd: RBAC: handle applicationsets #11996

Open
3 tasks done
shuker85 opened this issue Jan 16, 2023 · 0 comments
Open
3 tasks done

ArgoCD cmd: RBAC: handle applicationsets #11996

shuker85 opened this issue Jan 16, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@shuker85
Copy link
Contributor

Checklist:

  • I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
  • I've included steps to reproduce the bug.
  • I've pasted the output of argocd version.

Describe the bug

argocd admin settings rbac does not work with applicationsets RBAC
To Reproduce

# argocd admin settings rbac can role:devops create applicationsets 'default/*' --policy-file argo/policy.csv
FATA[0000] error in RBAC request: 'applicationsets' is not a valid resource name

#policy.csv
p, role:devops, applicationsets, *, microservices/*, allow
p, role:devops, applicationsets, *, default/*, allow
....

Expected behavior

Screenshots

Version

argocd version 
argocd: v2.5.6+9db2c94.dirty

Logs

Paste any relevant application logs here.

I'll try to get a fix with proper tests soon. Thanks @crenshaw-dev for pointing the related code.
@shuker85 shuker85 added the bug Something isn't working label Jan 16, 2023
@shuker85 shuker85 mentioned this issue Jan 16, 2023
Merged
10 tasks
shuker85 added a commit to shuker85/argo-cd that referenced this issue Mar 18, 2023
@shuker85
ArgoCD admin cmd: handle applicationsets RBAC
9325232 
Fixes [argoproj#11996]

Adding more tests on logs/exec

Signed-off-by: Shyukri Shyukriev <shyukri.shyukriev@mariadb.com>
crenshaw-dev added a commit that referenced this issue May 29, 2023
@shuker85 @crenshaw-dev
fix(appset): ArgoCD admin cmd: handle applicationsets RBAC (#11997)
4c982b2 
Fixes [#11996]

Adding more tests on logs/exec

Signed-off-by: Shyukri Shyukriev <shyukri.shyukriev@mariadb.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
yyzxw pushed a commit to yyzxw/argo-cd that referenced this issue Aug 9, 2023
@shuker85 @crenshaw-dev
fix(appset): ArgoCD admin cmd: handle applicationsets RBAC (argoproj…
7d749ba 
…#11997)

Fixes [argoproj#11996]

Adding more tests on logs/exec

Signed-off-by: Shyukri Shyukriev <shyukri.shyukriev@mariadb.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
tesla59 pushed a commit to tesla59/argo-cd that referenced this issue Dec 16, 2023
@shuker85 @crenshaw-dev @tesla59
fix(appset): ArgoCD admin cmd: handle applicationsets RBAC (argoproj…
ee1c452 
…#11997)

Fixes [argoproj#11996]

Adding more tests on logs/exec

Signed-off-by: Shyukri Shyukriev <shyukri.shyukriev@mariadb.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shuker85