Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add site_url in mkdocs.yml for broken stylesheet links in 404 page #1143

Conversation

jeongukjae
Copy link
Collaborator

Pull Request Checklist

Description of PR

Currently, 404 page is not rendered properly because stylesheet links are broken in there.
(details are described in the linked issue)
This PR adds site_url attribute in mkdocs.yml for the workaround of #1142 .

if css hash has changed, it can be broken again in 404 page of outdated docs.
but with this workaround, at least latest docs will be rendered properly.

Signed-off-by: Ukjae Jeong <jeongukjae@gmail.com>
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.3%. Comparing base (d553546) to head (9bd3494).
Report is 116 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1143     +/-   ##
=======================================
- Coverage   81.7%   81.3%   -0.4%     
=======================================
  Files         54      60      +6     
  Lines       4208    4720    +512     
  Branches     889    1000    +111     
=======================================
+ Hits        3439    3842    +403     
- Misses       574     647     +73     
- Partials     195     231     +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jeongukjae jeongukjae force-pushed the jeongukjae/add-site-url-for-broken-links-in-404 branch from 67f8cfc to adb6640 Compare July 31, 2024 13:51
mkdocs.yml Outdated Show resolved Hide resolved
Co-authored-by: Elliot Gunton <elliotgunton@gmail.com>
Signed-off-by: Ukjae Jeong <JeongUkJae@gmail.com>
@elliotgunton elliotgunton added semver:patch A change requiring a patch version bump type:documentation A documentation update labels Jul 31, 2024
@elliotgunton elliotgunton merged commit b17138f into argoproj-labs:main Jul 31, 2024
21 of 24 checks passed
@jeongukjae jeongukjae deleted the jeongukjae/add-site-url-for-broken-links-in-404 branch August 9, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch A change requiring a patch version bump type:documentation A documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

404 page's stylesheet links are broken
2 participants